Skip to content

Conversation

@anwesha-palit-redhat
Copy link
Contributor

@anwesha-palit-redhat anwesha-palit-redhat commented Jan 9, 2026

Fix: Preserve whitespace in log viewer with horizontal scrolling

This PR fixes the log viewer to properly display logs with long lines by enabling horizontal scrolling while preserving whitespace formatting.

Changes:

  • Enabled text wrapping in PatternFly LogViewer components (isTextWrapped={true})
  • Added CSS overrides to enforce white-space: pre to preserve formatting
  • Enabled horizontal scroll for log viewer containers
  • Minor layout fix for PipelineRun details page header alignment

This ensures logs with long lines are readable without text wrapping breaking the original formatting, while still allowing users to scroll horizontally to view full content.

Screen recording before:

Screen.Recording.2026-01-15.at.12.36.23.mov

Screen recording after:

Logs_after.mov
Screen.Recording.2026-01-15.at.12.31.40.mov

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2026
@anwesha-palit-redhat
Copy link
Contributor Author

/cherry-pick main_ocp_4.22

@openshift-cherrypick-robot

@anwesha-palit-redhat: once the present PR merges, I will cherry-pick it on top of main_ocp_4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick main_ocp_4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@anwesha-palit-redhat anwesha-palit-redhat changed the title fix: updated textwrapper flag for logviewer SRVKP-10035: updated textwrapper flag for logviewer Jan 9, 2026
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 9, 2026

@anwesha-palit-redhat: This pull request references SRVKP-10035 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 15, 2026

@anwesha-palit-redhat: This pull request references SRVKP-10035 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Fix: Preserve whitespace in log viewer with horizontal scrolling

This PR fixes the log viewer to properly display logs with long lines by enabling horizontal scrolling while preserving whitespace formatting.

Changes:

  • Enabled text wrapping in PatternFly LogViewer components (isTextWrapped={true})
  • Added CSS overrides to enforce white-space: pre to preserve formatting
  • Enabled horizontal scroll for log viewer containers
  • Minor layout fix for PipelineRun details page header alignment

This ensures logs with long lines are readable without text wrapping breaking the original formatting, while still allowing users to scroll horizontally to view full content.

Screen recording before:

Screen.Recording.2026-01-15.at.12.36.23.mov

Screen recording after:

Logs_after.mov
Screen.Recording.2026-01-15.at.12.31.40.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anwesha-palit-redhat anwesha-palit-redhat changed the title SRVKP-10035: updated textwrapper flag for logviewer SRVKP-10035: Preserve whitespace in log viewer with horizontal scrolling Jan 15, 2026
@anwesha-palit-redhat anwesha-palit-redhat marked this pull request as ready for review January 15, 2026 07:08
@openshift-ci openshift-ci bot requested a review from pratap0007 January 15, 2026 07:08
@arvindk-softwaredev
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 19, 2026
@anwesha-palit-redhat anwesha-palit-redhat merged commit c373d1e into openshift-pipelines:main Jan 21, 2026
4 of 7 checks passed
@openshift-cherrypick-robot

@anwesha-palit-redhat: #866 failed to apply on top of branch "main_ocp_4.22":

Applying: fix: css fix for logviewer to preserve whitespace
Using index info to reconstruct a base tree...
M	src/components/logs/LogsWrapperComponent.tsx
M	src/components/logs/MultiStreamLogs.scss
M	src/components/logs/MultiStreamLogs.tsx
M	src/components/logs/TektonTaskRunLog.tsx
M	src/components/pipelineRuns-details/PipelineRunDetailsPage.tsx
M	src/components/pipelineRuns-details/PipelineRunLogs.scss
M	src/components/pipelineRuns-details/PipelineRunLogs.tsx
M	src/components/pipelines-tasks/tasks-details-pages/TaskRunLog.scss
Falling back to patching base and 3-way merge...
Auto-merging src/components/pipelines-tasks/tasks-details-pages/TaskRunLog.scss
CONFLICT (content): Merge conflict in src/components/pipelines-tasks/tasks-details-pages/TaskRunLog.scss
Auto-merging src/components/pipelineRuns-details/PipelineRunLogs.tsx
CONFLICT (content): Merge conflict in src/components/pipelineRuns-details/PipelineRunLogs.tsx
Auto-merging src/components/pipelineRuns-details/PipelineRunLogs.scss
CONFLICT (content): Merge conflict in src/components/pipelineRuns-details/PipelineRunLogs.scss
Auto-merging src/components/pipelineRuns-details/PipelineRunDetailsPage.tsx
CONFLICT (content): Merge conflict in src/components/pipelineRuns-details/PipelineRunDetailsPage.tsx
Auto-merging src/components/logs/TektonTaskRunLog.tsx
CONFLICT (content): Merge conflict in src/components/logs/TektonTaskRunLog.tsx
Auto-merging src/components/logs/MultiStreamLogs.tsx
CONFLICT (content): Merge conflict in src/components/logs/MultiStreamLogs.tsx
CONFLICT (modify/delete): src/components/logs/MultiStreamLogs.scss deleted in fix: css fix for logviewer to preserve whitespace and modified in HEAD. Version HEAD of src/components/logs/MultiStreamLogs.scss left in tree.
Auto-merging src/components/logs/LogsWrapperComponent.tsx
CONFLICT (content): Merge conflict in src/components/logs/LogsWrapperComponent.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: css fix for logviewer to preserve whitespace

Details

In response to this:

/cherry-pick main_ocp_4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants