AGENT-1511: Support multi node HA ( 3/4/5 control planes) Cluster Topology for OVE NoRegistry#1884
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| if [[ "${AGENT_E2E_TEST_BOOT_MODE}" == "ISO_NO_REGISTRY" ]]; then | ||
| if [[ "${AGENT_E2E_TEST_SCENARIO}" != "COMPACT_IPV4" && "${AGENT_E2E_TEST_SCENARIO}" != "5CONTROL_IPV4" ]]; then | ||
| printf "\nInvalid AGENT_E2E_TEST_SCENARIO '%s' for AGENT_E2E_TEST_BOOT_MODE='ISO_NO_REGISTRY'.\n" "${AGENT_E2E_TEST_SCENARIO}" | ||
| printf "When using ISO_NO_REGISTRY boot mode, only 'COMPACT_IPV4' and '5CONTROL_IPV4' are supported.\n" |
There was a problem hiding this comment.
This validation will be later updated as we support more version of OVE
There was a problem hiding this comment.
But do we really need it now? I feel slightly more confused with it
There was a problem hiding this comment.
Its rare that someone else will add an invalid config as we are the only ones who are using the configurations. The validation added because there is exisiting validation for agent automated scenatios.
openshift-ci
Bot
requested review from
andfasano,
bfournie,
rwsu and
sadasu
and removed request for
celebdor and
lranjbar
| } | ||
|
|
||
| menuItem.MustClick() | ||
| time.Sleep(500 * time.Millisecond) |
There was a problem hiding this comment.
Q: why all these sleeps? IIRC there was a default way in go-rod to "slow down" a little bit the operations
There was a problem hiding this comment.
That was the existing pattern used but I agree to remove time.sleep and use the go-rod's supported functions instead. I will open a new follow up PR for fixing the existing ones.
There was a problem hiding this comment.
to be clear, I remove the time.sleep added originally in this PR. There are still existing time.sleep() calls in the automation script which I will remove gradually in a follow up PR as an improvement.
cc @andfasano @bfournie
pawanpinjarkar
changed the title
| // selectControlPlaneCount selects the specified control plane count from the dropdown | ||
| func selectControlPlaneCount(page *rod.Page, count int, screenshotPath string) error { | ||
| // Validate input | ||
| if count < 1 || count > 5 { |
There was a problem hiding this comment.
Should 2 control plane nodes be excluded? The title says 3/4/5 control plane nodes.
There was a problem hiding this comment.
yes, TNA is not supported
There was a problem hiding this comment.
TNA option will be removed from the UI https://redhat.atlassian.net/browse/OCPBUGS-84331
pawanpinjarkar
force-pushed
the
5-control-plane-node-support-4-ove
branch
from
9e5352b to
5e3bcc7
Compare
pawanpinjarkar
force-pushed
the
5-control-plane-node-support-4-ove
branch
from
5e3bcc7 to
f6e9598
Compare
3 participants
Support multi node HA ( 3/4/5 control planes) Cluster Topology for OVE NoRegistry Flow in dev-scripts and UI Automation