utils: emit disableCertificateVerification for idrac driver#1861
utils: emit disableCertificateVerification for idrac driver#1861bogdando wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
The disableCertificateVerification field in install-config.yaml is only emitted when driver_prefix was "redfish". The idrac driver sets driver_prefix to "drac", so the block was skipped entirely, causing Ironic to verify the BMC's self-signed certificate and fail with SSL: CERTIFICATE_VERIFY_FAILED. Extend the condition to also cover the "drac" prefix so that redfish_verify_ca from the nodes JSON is honoured for Dell iDRAC hardware. Generated-By: Cursor (claude-4.6-opus-high) Signed-off-by: Bohdan Dobrelia <bdobreli@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @bogdando. Thanks for your PR. I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
for the record, we need this fix in RHOSO CI for a custom SNO BM setup by dev-scripts, where I could not use Redfish virtual media driver, so tried the idrac one, and hit the subj issue |
The disableCertificateVerification field in install-config.yaml is only emitted when driver_prefix was "redfish". The idrac driver sets driver_prefix to "drac", so the block was skipped entirely, causing Ironic to verify the BMC's self-signed certificate and fail with SSL: CERTIFICATE_VERIFY_FAILED.
Extend the condition to also cover the "drac" prefix so that redfish_verify_ca from the nodes JSON is honoured for Dell iDRAC hardware.
Generated-By: Cursor (claude-4.6-opus-high)