NO-JIRA: feat: add version check for sno req and add sno e2e config#1858
NO-JIRA: feat: add version check for sno req and add sno e2e config#1858eggfoobar wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
|
/assign @andfasano |
|
/retest-required |
eggfoobar
force-pushed
the
add-version-check-for-snomin
branch
from
7e5ddc9 to
e0491ad
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
eggfoobar
force-pushed
the
add-version-check-for-snomin
branch
from
e0491ad to
473573f
Compare
SNO ABI flow will support min 4vCPU in 4.22 and above, so older versions will not pass validation adding check to fail early Removed SNOMIN in favor of setting the default across the board Added SNOE2E to capture testing where more vcpu is required Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
add-version-check-for-snomin
branch
from
473573f to
7672a42
Compare
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
eggfoobar
changed the title
2 participants
SNOMIN 4vCPU SNO in ABI will only be changed in 4.22 and above, so older versions will not pass validation
adding check to fail early