Update go2rtc_integration.c#426
Open
rivandraa wants to merge 1 commit into
Open
Conversation
Contributor
rivandraa
commented
May 25, 2026
rivandraa
commented
- Updated all go2rtc_stream_register calls for sub‑streams to enable the true flag in the parameter list (previously set to false).
- This adjustment applies consistently across:
- Registration from streams[i].sub_stream_url
- Registration from db_streams[i].sub_stream_url
- Registration from config.sub_stream_url
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes how {name}_sub streams are registered with go2rtc by flipping the record_audio boolean parameter in go2rtc_stream_register(...) from false to true for sub-stream registrations performed by the go2rtc integration layer.
Changes:
- Enable the
record_audioflag when registering sub-streams during “register all streams”. - Enable the
record_audioflag when registering missing sub-streams during database sync. - Enable the
record_audioflag when registering a single stream’s sub-stream.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| streams[i].onvif_username[0] != '\0' ? streams[i].onvif_username : NULL, | ||
| streams[i].onvif_password[0] != '\0' ? streams[i].onvif_password : NULL, | ||
| false, streams[i].protocol, false, | ||
| false, streams[i].protocol, true, |
Comment on lines
1551
to
1555
| log_info("Registering missing sub-stream %s with go2rtc", sub_name); | ||
| go2rtc_stream_register(sub_name, db_streams[i].sub_stream_url, | ||
| username, password, | ||
| false, db_streams[i].protocol, false, | ||
| false, db_streams[i].protocol, true, | ||
| db_streams[i].codec); |
Comment on lines
1951
to
1955
| go2rtc_stream_register(sub_name, config.sub_stream_url, | ||
| username[0] != '\0' ? username : NULL, | ||
| password[0] != '\0' ? password : NULL, | ||
| false, config.protocol, false, | ||
| false, config.protocol, true, | ||
| config.codec); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.