added isnotnull condition support#5278
added isnotnull condition support#5278ThyTran1402 wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Thy Tran <58045538+ThyTran1402@users.noreply.github.com>
|
Failed to generate code suggestions for PR |
Signed-off-by: Thy Tran <58045538+ThyTran1402@users.noreply.github.com>
|
Failed to generate code suggestions for PR |
|
Do you know why it did not pass the tests 😢 ? @Swiddis |
|
Unit tests are failing due to spotless violations, it says how to fix them here: https://github.com/opensearch-project/sql/actions/runs/23671443599/job/68965646433?pr=5278#step:6:9358 Doctests are failing because the cluster is returning incorrect results: https://github.com/opensearch-project/sql/actions/runs/23671443599/job/68965646435?pr=5278#step:6:661 Are you running these locally before pushing? Integ tests are slow locally, but at least If you want to work on this interactively, I'm available on the opensearch slack |
Description
Adds support for field IS [NOT] NULL as a predicate syntax in PPL, as a synonym for the existing
isnull(field)/isnotnull(field)functions.Previously, users coming from a SQL background would naturally write where field is not null in PPL, only to receive a parse error with no guidance.
Related Issues
Resolves #5262
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.