Skip to content

added isnotnull condition support#5278

Open
ThyTran1402 wants to merge 2 commits intoopensearch-project:mainfrom
ThyTran1402:feat/add_isnotnull_condition_support
Open

added isnotnull condition support#5278
ThyTran1402 wants to merge 2 commits intoopensearch-project:mainfrom
ThyTran1402:feat/add_isnotnull_condition_support

Conversation

@ThyTran1402
Copy link
Copy Markdown
Contributor

@ThyTran1402 ThyTran1402 commented Mar 27, 2026

Description

Adds support for field IS [NOT] NULL as a predicate syntax in PPL, as a synonym for the existing isnull(field) / isnotnull(field) functions.
Previously, users coming from a SQL background would naturally write where field is not null in PPL, only to receive a parse error with no guidance.

Related Issues

Resolves #5262

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thy Tran <58045538+ThyTran1402@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@Swiddis Swiddis added the enhancement New feature or request label Mar 27, 2026
@Swiddis Swiddis self-assigned this Mar 27, 2026
@Swiddis Swiddis added PPL Piped processing language integ-test-failure Integration test failures labels Mar 27, 2026
Signed-off-by: Thy Tran <58045538+ThyTran1402@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@ThyTran1402
Copy link
Copy Markdown
Contributor Author

Do you know why it did not pass the tests 😢 ? @Swiddis

@Swiddis
Copy link
Copy Markdown
Collaborator

Swiddis commented Mar 30, 2026

Unit tests are failing due to spotless violations, it says how to fix them here: https://github.com/opensearch-project/sql/actions/runs/23671443599/job/68965646433?pr=5278#step:6:9358

Doctests are failing because the cluster is returning incorrect results: https://github.com/opensearch-project/sql/actions/runs/23671443599/job/68965646435?pr=5278#step:6:661

Are you running these locally before pushing? Integ tests are slow locally, but at least ./gradlew spotlessApply spotlessCheck test doctest should get you most of the way there. You can always check the test action to see exactly what each CI check is doing. I also recommend setting up pre-commit, which will connect with our pre-commit steps to auto-fix your formatting on every commit.

If you want to work on this interactively, I'm available on the opensearch slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request integ-test-failure Integration test failures PPL Piped processing language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] IS NOT NULL condition support

2 participants