Add scope: test to AddDependency invocations for test libraries #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several testing migration recipes were adding test dependencies (assertj-core, mockito-core, hamcrest, vertx-junit5) without specifying scope: test. This caused the dependencies to be added with implementation scope instead of testImplementation in Gradle builds. Affected recipes: - JUnitToAssertj (assertj.yml) - MigrateHamcrestToAssertJ (hamcrest.yml) - AddHamcrestIfUsed (hamcrest.yml) - MigrateTruthToAssertJ (truth.yml) - TestNgToAssertj (testng.yml) - JMockitToMockito (jmockit.yml) - EasyMockToMockito (easymock.yml) - VertxUnitToVertxJunit5 (junit5.yml)
Add tests for Maven and Gradle that verify: - EasyMockToMockito adds mockito-core with test scope - TestNgToAssertj adds assertj-core with test scope - JMockitToMockito adds mockito-core with test scope
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| */ | ||
| package org.openrewrite.java.testing.jmockit; | ||
|
|
||
| import org.junit.jupiter.api.Test; |
Contributor
There was a problem hiding this comment.
Suggested change
| import org.junit.jupiter.api.Test; | |
| import org.junit.jupiter.api.Test; | |
| import org.openrewrite.DocumentExample; |
| setDefaultParserSettings(spec); | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
Suggested change
| @Test | |
| @DocumentExample | |
| @Test |
This test proves that explicit scope: test is required when test libraries are used in main sources (e.g., test utilities). Without explicit scope, auto-detection uses compile scope.
| */ | ||
| package org.openrewrite.java.testing.jmockit; | ||
|
|
||
| import org.junit.jupiter.api.Test; |
Contributor
There was a problem hiding this comment.
Suggested change
| import org.junit.jupiter.api.Test; | |
| import org.junit.jupiter.api.Test; | |
| import org.openrewrite.DocumentExample; |
| setDefaultParserSettings(spec); | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
Suggested change
| @Test | |
| @DocumentExample | |
| @Test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several testing migration recipes were adding test dependencies without specifying
scope: test, causing them to be added asimplementationscope instead oftestImplementationin Gradle builds.This fix adds
scope: testto the followingAddDependencyinvocations:assertj-corein JUnitToAssertj, MigrateHamcrestToAssertJ, MigrateTruthToAssertJ, TestNgToAssertjhamcrestin AddHamcrestIfUsedmockito-corein JMockitToMockito, EasyMockToMockitovertx-junit5in VertxUnitToVertxJunit5Fixes moderneinc/customer-requests#760
Test plan