Harden PinGitHubActionsToSha tests against SHA drift#196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PinGitHubActionsToShaTestcases pinned their expected output to bare major action tags (@v3,@v4,@v5), whose SHAs the weeklyupdate-known-shasjob re-resolves whenever an upstream maintainer re-points the major tag, forcing repeated manual test fixes (Update stale codeql-action SHA in PinGitHubActionsToShaTest #186, Update known action SHAs #188, Update known action SHAs #192). This switches every SHA-bearing test reference to a fully-qualified immutable patch tag (e.g.codecov/codecov-action@v4.6.0,github/codeql-action/init@v3.36.2), which the refresh script treats as immutable and never rewrites. The chosen patch tags currently resolve to the same commits as the old major tags, so only the input tags and# vXversion comments change — the expected SHAs are identical. All tests pass.