Downstream UDP support by alonbg · Pull Request #38 · openresty/stream-lua-nginx-module

alonbg · 2016-09-08T12:31:11Z

Original pull-request was closed as I branched this feature during some repo house keeping.

bjne · 2016-10-25T20:31:48Z

&ngx_stream_lua_skcoet_tcp_metatable_key

skcoet -> socket

Conflicts: src/ngx_stream_lua_socket_tcp.c src/ngx_stream_lua_socket_udp.h

alonbg · 2016-11-01T16:04:57Z

@agentzh, t/099-c-api.t passes on my end but fails on the CI (unable to connect)
Any ideas? Thanks

agentzh · 2016-11-01T16:48:42Z

@alonbg Seems like 099-c-api.t causes the nginx server process to crash. Better use valgrind to locate the memory issues on your side.

alonbg · 2016-11-01T17:36:36Z

export TEST_NGINX_USE_VALGRIND=1; ./go prove -r t/099-c-api.t 1> out.txt 2>&1
@agentzh, sorry :( but I didn't know what to make out of it. attached
out.txt

doujiang24 · 2016-11-15T10:41:28Z

@agentzh @alonbg
I think the 099-c-api.t failed is because the ngx_http_lua_module changed.
I have created a PR for that #44

And, @agentzh have mark these test cases SKIP, so rebase the lastest master will goes right :)

doujiang24

@alonbg Nice job!

doujiang24 · 2016-11-17T09:58:49Z

src/ngx_stream_lua_socket_tcp.c

+{
+    lua_pushcfunction(L, ngx_stream_lua_tcp_req_socket);
+    lua_setfield(L, -2, "socket");
+}


better keep this function in the same place (before ngx_stream_lua_socket_tcp) that will have a better diff :)

doujiang24 · 2016-11-17T09:59:15Z

src/ngx_stream_lua_socket_tcp.c

    ngx_peer_connection_t           *pc;
    ngx_stream_lua_srv_conf_t       *lscf;
    ngx_connection_t                *c;
-    ngx_stream_session_t            *s;


doujiang24 · 2016-11-17T10:00:07Z

src/ngx_stream_lua_socket_tcp.c


+    if (c->type != SOCK_STREAM) {
+        return luaL_error(L, "socket api does not match connection transport",
+                          lua_gettop(L));


better remove lua_gettop here?

doujiang24 · 2016-11-17T10:15:30Z

src/ngx_stream_lua_socket_udp.c

+
+    if (c->type != SOCK_DGRAM) {
+        return luaL_error(L, "socket api does not match connection transport",
+                          lua_gettop(L));


doujiang24 · 2016-11-18T11:05:20Z

src/ngx_stream_lua_socket_udp.c

+    ctx->acquired_raw_req_socket = 1;
+#endif
+
+    lua_createtable(L, 3 /* narr */, 1 /* nrec */); /* the object */


Seems 2 narr is enough?

doujiang24 · 2016-11-18T15:56:04Z

src/ngx_stream_lua_socket_udp.c

+    c = s->connection;

-    ngx_log_debug1(NGX_LOG_DEBUG_STREAM, s->connection->log, 0,
+    ngx_log_debug1(NGX_LOG_DEBUG_STREAM, c->log, 0,


seems this change not so necessary ?

doujiang24 · 2016-11-18T15:57:23Z

t/065-tcp-socket-timeout.t

 --- timeout: 10


-


style: three blank lines needed, so we should keep this line :)

doujiang24 · 2016-11-19T06:09:10Z

src/ngx_stream_lua_socket_udp.c

+        u->received = c->buffer->last - c->buffer->pos;
+        c->buffer->pos =
+            ngx_copy(ngx_stream_lua_socket_udp_buffer, c->buffer->pos,
+                     u->received);


style: I think this will be better:

c->buffer->pos = ngx_copy(ngx_stream_lua_socket_udp_buffer, c->buffer->pos, u->received);

doujiang24 · 2016-11-19T06:12:16Z

t/140-raw-req-udp-socket.t

+mysock handler aborted
+--- no_error_log
+[error]
+--- wait: 1.1


Seems wait: 0.3 is enough ?

doujiang24 · 2016-11-19T06:19:36Z

@alonbg I think we'd better create a new directory like t/087-udp-socket and move the udp test files into it.
We'd better keep the same test file number as in lua-nginx-module, what do you think?

monkeylite · 2017-03-09T18:39:45Z

When would this PR be merged/released? badly needed:(

alonbg changed the title ~~Udp support~~ UDP support Sep 8, 2016

alonbg changed the title ~~UDP support~~ Downstream UDP support Sep 8, 2016

alonbg mentioned this pull request Sep 8, 2016

udp downstream api - work in progress #28

Closed

alonbg force-pushed the udp_support branch from b392061 to d60c2fb Compare September 18, 2016 08:18

alonbg force-pushed the udp_support branch from d60c2fb to bd93fec Compare November 1, 2016 15:17

udp downstream api - work in progress

acd5242

Conflicts: src/ngx_stream_lua_socket_tcp.c src/ngx_stream_lua_socket_udp.h

alonbg force-pushed the udp_support branch from bd93fec to acd5242 Compare November 1, 2016 15:48

doujiang24 reviewed Nov 18, 2016

View reviewed changes

doujiang24 reviewed Nov 19, 2016

View reviewed changes

zhuizhuhaomeng force-pushed the master branch from 616f118 to cd24241 Compare January 20, 2026 14:21

Conversation

alonbg commented Sep 8, 2016

Uh oh!

bjne commented Oct 25, 2016

Uh oh!

alonbg commented Nov 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agentzh commented Nov 1, 2016

Uh oh!

alonbg commented Nov 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doujiang24 commented Nov 15, 2016

Uh oh!

doujiang24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

doujiang24 commented Nov 19, 2016

Uh oh!

monkeylite commented Mar 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alonbg commented Nov 1, 2016 •

edited

Loading

alonbg commented Nov 1, 2016 •

edited

Loading