Add ngx_http_lua_ffi_shdict_store_when for set_when and safe_set_when#1574
Open
hnakamur wants to merge 3 commits intoopenresty:masterfrom
Open
Add ngx_http_lua_ffi_shdict_store_when for set_when and safe_set_when#1574hnakamur wants to merge 3 commits intoopenresty:masterfrom
hnakamur wants to merge 3 commits intoopenresty:masterfrom
Conversation
Contributor
Author
|
Test with the following pull request branches passes at https://travis-ci.org/hnakamur/lua-nginx-module/builds/569371351 |
f924579 to
fef2581
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
ngx_http_lua_ffi_shdict_store_whenwhich is used to define
set_whenandsafe_set_whenmethods inngx.shared.DICT.These methods are useful for avoiding race conditions between successive calls of
getandset.You pass
old_valueas well asvaluetoset_when, and it changes the value only when the value for the key is still the same asold_value.Adding this method is suggested in the comment by @doujiang24.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.