Align EmsGOPACSAsset UI panels with documented attribute groupings#37
Open
Miggets7 wants to merge 4 commits into
Open
Align EmsGOPACSAsset UI panels with documented attribute groupings#37Miggets7 wants to merge 4 commits into
Miggets7 wants to merge 4 commits into
Conversation
Renames the "Status" group to "Announcement" so it matches the new "Redispatch — Announcement" panel title in asset-types.json, and reorders the Bid rows so the operator-editable redispatchBidPrice is listed before the read-only suggestion rows, mirroring the in-UI panel order.
Splits the single "Configuration" panel so contractedEAN (shared) and redispatchEnabled (redispatch-only) live in their own groups, relabels the UFTP panel to reflect intraday flex traffic and splits it into Flex Request / Flex Order, separates Redispatch Bid (price and suggestions) from Workflow (confirm + status state machine), and surfaces redispatchAnnouncementHistory / redispatchBidHistory as an explicit "Redispatch — History" panel. Operator-editable attributes are placed first within their panel. Closes openremote/denhaag#162.
Mirrors the EmsEnergyOptimisationAsset layout: a hideOnMobile notes panel at the top of the main column, and the standard sidebar trio (location, history, linkedUsers) in column 1, so the GOPACS asset page picks up free-text notes plus the platform's location, history-timeline and access-management widgets.
Member
|
Adding this to the internal sprint board, as it's a separate PR from the one in the D***** custom project. |
Contributor
Suggestions:
|
Contributor
Author
|
@pierrekil agreed with Igor's suggestions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reorganises the
EmsGOPACSAssetpanels inems/src/main/resources/ems/config/asset-types.jsonso that an operator can tell at a glance which attributes belong to which flow. The current single-page layout mixes shared, UFTP-intraday, and redispatch concerns and merges Bid and Workflow attributes into one panel.This is the EMS-extension default that
EmsOptimisationSetupService.updateManagerConfig()merges into the running manager config when an operator triggers theCREATE_ENERGY_MANAGEMENT_SYSTEMflow.What changed
ems/README.md) — renamed the Status group to Announcement and reordered the Bid rows so the operator-editableredispatchBidPriceis listed before the read-only suggestion rows.asset-types.json) — eightinfopanels in the main column:notes(hideOnMobile)contractedEANcurrentPower*,power{Maximum,Minimum}FlexRequestpowerLimit{Maximum,Minimum}ProfileFlexOrderredispatchBidPricefirst, then suggestionsredispatchConfirmBidfirst, thenredispatchBidStatusredispatchAnnouncement/BidHistorylocation, built-in history timeline,linkedUsers, plusRedispatch — Configuration(theredispatchEnabledtoggle) andRedispatch — Announcement(status fields).