-
Notifications
You must be signed in to change notification settings - Fork 81
Bids comparison #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
annawzz
wants to merge
6
commits into
openprocurement:eauction-devel
Choose a base branch
from
annawzz:reading_from_artifact
base: eauction-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bids comparison #451
annawzz
wants to merge
6
commits into
openprocurement:eauction-devel
from
annawzz:reading_from_artifact
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion. op_robot_tests/tests_files/service_keywords.py, line 551 at r1 (raw file):
Створення словника можна замінити на Comments from Reviewable |
Also, add to artifact: 1) bid start values; 2) difference between start and changed bid values. That's needed to compare bids in qualification period.
Also, add roles in suites where needed.
Check matching of start bid values and bid values in qualification period, taking into account changes in tendering and auction periods.
Depending on the role, try to read bid id from artifact. If artifact doesn't exist, read it from bidresponses (or tender.data.awards).
5b565ef to
90da5ed
Compare
Author
|
Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion. op_robot_tests/tests_files/service_keywords.py, line 551 at r1 (raw file): Previously, mykhaly (Yurii Mykhalchuk) wrote…
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is