Skip to content

Conversation

@annawzz
Copy link

@annawzz annawzz commented Jan 26, 2017

  1. Rewrite artifact in python
  2. Add comparison of bids (start values and values in qualification period, taking into account changes in tendering and auction periods)
  3. Add reading bid IDs from artifact where it's possible.

This change is Reviewable

@mykhaly
Copy link
Contributor

mykhaly commented Jan 27, 2017

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion.


op_robot_tests/tests_files/service_keywords.py, line 551 at r1 (raw file):

def create_artifact(api, tender_data, mode, users, tender_owner, provider, provider1):
    artifact = {}
    artifact['api_version'] = api

Створення словника можна замінити на

artifact = {
    'mode': mode,
    'tender_uaid': tender_data.get('TENDER_UAID', ''),
    'last_modification_date': tender_data.get('LAST_MODIFICATION_DATE', ''),
    'tender_owner': users[tender_owner].get('broker', ''),
    'access_token': users[tender_owner].get('access_token', ''),
    'tender_id': users[tender_owner]['tender_data']['data'].get('id', ''),
    'provider_access_token': users[provider].get('access_token', ''),
    'provider1_access_token': users[provider1].get('access_token', ''),
    'provider_bid_id': users[provider].get('bid_id', ''),
    'provider1_bid_id': users[provider1].get('bid_id', ''),
    'provider_bid_start_value': users[provider].get('bid_start_value','')
}

Comments from Reviewable

@selurvedu selurvedu self-assigned this Jan 27, 2017
Also, add to artifact:
1) bid start values;
2) difference between start and changed bid values.
That's needed to compare bids in qualification period.
Also, add roles in suites where needed.
Check matching of start bid values and bid values in qualification period, taking into account changes in tendering and auction periods.
Depending on the role, try to read bid id from artifact. If artifact doesn't exist, read it from bidresponses (or tender.data.awards).
@annawzz annawzz force-pushed the reading_from_artifact branch from 5b565ef to 90da5ed Compare January 30, 2017 14:48
@annawzz
Copy link
Author

annawzz commented Jan 30, 2017

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion.


op_robot_tests/tests_files/service_keywords.py, line 551 at r1 (raw file):

Previously, mykhaly (Yurii Mykhalchuk) wrote…

Створення словника можна замінити на

artifact = {
    'mode': mode,
    'tender_uaid': tender_data.get('TENDER_UAID', ''),
    'last_modification_date': tender_data.get('LAST_MODIFICATION_DATE', ''),
    'tender_owner': users[tender_owner].get('broker', ''),
    'access_token': users[tender_owner].get('access_token', ''),
    'tender_id': users[tender_owner]['tender_data']['data'].get('id', ''),
    'provider_access_token': users[provider].get('access_token', ''),
    'provider1_access_token': users[provider1].get('access_token', ''),
    'provider_bid_id': users[provider].get('bid_id', ''),
    'provider1_bid_id': users[provider1].get('bid_id', ''),
    'provider_bid_start_value': users[provider].get('bid_start_value','')
}
</blockquote></details>

Замінила, + внесла ще деякі правки.

---


*Comments from [Reviewable](https://reviewable.io:443/reviews/openprocurement/robot_tests/451)*
<!-- Sent from Reviewable.io -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants