Add flows bulk actions#2263
Open
rmnsnpk wants to merge 16 commits into
Open
Conversation
…ce before displaying sort icon
…le and HomeRunsTable components
…ctions Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # packages/react-ui/src/app/routes/flows/index.tsx # packages/server/api/src/app/app-connection/app-connection-service/app-connection-service.ts # packages/server/api/test/unit/app-connection/app-connection-service.test.ts # packages/ui-components/src/ui/data-table.tsx
… deleting, and exporting selected flows. Refactor related functions for improved readability and maintainability.
…tion column functionality.
Comment on lines
+456
to
+470
| async deleteMany({ | ||
| flowIds, | ||
| projectId, | ||
| userId, | ||
| }: DeleteManyParams): Promise<void> { | ||
| await Promise.all( | ||
| flowIds.map((id) => | ||
| this.delete({ | ||
| id, | ||
| projectId, | ||
| userId, | ||
| }), | ||
| ), | ||
| ); | ||
| }, |
Contributor
There was a problem hiding this comment.
would need validation:
- load all requested flows for the project first, verify the count matches the requested IDs (this checks the flows are in the respective project)
- no flow is internal (function could be accessed from other places)
- no flow is enabled (toast to explain in the UI)
Contributor
Author
There was a problem hiding this comment.
We allow user to delete single workflow when it's enabled. Are you sure we want to disable it for bulk?
Contributor
There was a problem hiding this comment.
I would add it for sure to prevent mistakes.
| [onTableRefresh, resetSelectedRows], | ||
| ); | ||
|
|
||
| const moveSelectedFlows = useCallback( |
Contributor
There was a problem hiding this comment.
move to Uncategoriezed does not work, I think we could remove that option (it does not exist also on flow level in the 3dots menu)
…rkflows during selection.
… enabled workflows. Add corresponding assertions in the flow service and enhance the FlowsPage UI with tooltips for user guidance.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is possible to delete the workflow in case it's enabled, so I think we should keep this behaviour for bulk operations