Enforce parent-scoped folder uniqueness with partial indexes

[MarceloRGonc]

Fixes OPS-4127

[linear]

OPS-4127 Allow folder with the same name but different parent

[Copilot]

Pull request overview

Adjusts folder uniqueness semantics to be scoped to a folder’s parent (root vs subfolder), aligning application behavior with new database constraints (OPS-4127).

Changes:

• Update folder lookups to include parentFolderId when checking for existing folders by display name.
• Replace TypeORM upsert with insert for folder creation and add a QueryFailedError fallback in getOrCreate.
• Add a migration that replaces the old global unique index with two partial unique indexes (root vs non-root).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
packages/server/api/src/app/flows/folder/folder.service.ts	Scopes “existing folder” checks by parentFolderId; changes create/getOrCreate behavior around inserts and DB constraint races.
packages/server/api/src/app/flows/folder/folder.entity.ts	Removes the previous unique index definition from the entity schema.
packages/server/api/src/app/database/migrations/1776097737024-FixFolderUniqueConstraint.ts	Drops old unique indexes and creates new partial unique indexes for root/non-root folders.

Comments suppressed due to low confidence (1)

packages/server/api/src/app/flows/folder/folder.service.ts:72

• update can still hit the DB unique index (e.g. concurrent rename/move into same parent) and folderRepo().update(...) would throw a QueryFailedError that becomes a 500 and may leak DB details. Consider catching unique-constraint failures here and translating them to an ApplicationError (e.g. ErrorCode.VALIDATION / conflict) similar to the pre-check.

    await folderRepo().update(folder.id, {
      displayName: request.displayName,
      parentFolder,
    });

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud