Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the existing Wizard UI components with a new MultiStepForm component suite, and migrates the benchmark wizard UI to use the new API (Fixes OPS-3931).
Changes:
- Removed the legacy
Wizardcomponent set and its exports. - Added a new
MultiStepFormcomponent set (container, header/content/footer, step, and step parts). - Updated Storybook and benchmark wizard usages to reference
MultiStepForm.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/ui/wizard/wizard.tsx | Removed legacy Wizard context + container component. |
| packages/ui-components/src/ui/wizard/wizard-header.tsx | Removed legacy Wizard header/title/close components. |
| packages/ui-components/src/ui/wizard/wizard-footer.tsx | Removed legacy Wizard footer/next/previous components. |
| packages/ui-components/src/ui/wizard/wizard-content.tsx | Removed legacy Wizard content wrapper. |
| packages/ui-components/src/ui/wizard/index.ts | Removed Wizard barrel exports. |
| packages/ui-components/src/ui/multi-step-form/multi-step-form.tsx | Added MultiStepForm context, navigation helpers, and controlled/uncontrolled support. |
| packages/ui-components/src/ui/multi-step-form/multi-step-form-step.tsx | Added step component that registers itself and optional step validation hook. |
| packages/ui-components/src/ui/multi-step-form/multi-step-form-step-parts.tsx | Kept step title/description/body parts; removed WizardStep export. |
| packages/ui-components/src/ui/multi-step-form/multi-step-form-header.tsx | Added MultiStepForm header/title/close components. |
| packages/ui-components/src/ui/multi-step-form/multi-step-form-footer.tsx | Added MultiStepForm footer/next/previous navigation buttons. |
| packages/ui-components/src/ui/multi-step-form/multi-step-form-content.tsx | Added MultiStepForm content wrapper. |
| packages/ui-components/src/ui/multi-step-form/index.ts | Added MultiStepForm barrel exports. |
| packages/ui-components/src/stories/multi-step-form/multi-step-form.stories.tsx | Migrated story from Wizard to MultiStepForm. |
| packages/ui-components/src/index.ts | Exported multi-step-form and removed wizard export from the package entrypoint. |
| packages/ui-components/src/components/benchmark/benchmark-ready-step.tsx | Updated StepDescription import to the new multi-step-form location. |
| packages/react-ui/src/app/features/benchmark/components/benchmark-wizard.tsx | Migrated benchmark wizard container layout from Wizard to MultiStepForm. |
| packages/react-ui/src/app/features/benchmark/components/benchmark-wizard-footer.tsx | Migrated footer navigation controls from Wizard to MultiStepForm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
packages/ui-components/src/ui/multi-step-form/multi-step-form-footer.tsx
Show resolved
Hide resolved
packages/ui-components/src/ui/multi-step-form/multi-step-form-footer.tsx
Outdated
Show resolved
Hide resolved
packages/ui-components/src/ui/multi-step-form/multi-step-form-footer.tsx
Show resolved
Hide resolved
packages/ui-components/src/ui/multi-step-form/multi-step-form-header.tsx
Show resolved
Hide resolved
packages/ui-components/src/ui/multi-step-form/multi-step-form-footer.tsx
Show resolved
Hide resolved
packages/ui-components/src/ui/multi-step-form/multi-step-form-header.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+85
to
+90
| const goToNext = React.useCallback(async () => { | ||
| const validationFn = stepValidationsRef.current.get(effectiveStep); | ||
| if (validationFn) { | ||
| const isValid = await validationFn(); | ||
| if (!isValid) { | ||
| return false; |
packages/ui-components/src/ui/multi-step-form/multi-step-form-footer.tsx
Show resolved
Hide resolved
packages/ui-components/src/ui/multi-step-form/multi-step-form-footer.tsx
Outdated
Show resolved
Hide resolved
rSnapkoOpenOps
approved these changes
Mar 20, 2026
packages/ui-components/src/ui/multi-step-form/multi-step-form-footer.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+74
to
+81
| const handleClick = async (e: React.MouseEvent<HTMLButtonElement>) => { | ||
| onClick?.(e); | ||
| if (onNext) { | ||
| await onNext(); | ||
| } else { | ||
| await goToNext(); | ||
| } | ||
| }; |
Comment on lines
+58
to
+61
| const handleClick = (e: React.MouseEvent<HTMLButtonElement>) => { | ||
| onClick?.(e); | ||
| onClose?.(); | ||
| }; |
Comment on lines
+5
to
+6
| interface StepValidationFn { | ||
| (): boolean | Promise<boolean>; |
Collaborator
There was a problem hiding this comment.
[nitpick]
Suggested change
| interface StepValidationFn { | |
| (): boolean | Promise<boolean>; | |
| type StepValidationFn = () => boolean | Promise<boolean>; |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3931
Additional Notes
Verified benchmarks still works as expected