fix: handle malformed location header when using next/navigation redirect API #3332
+115
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test all versions
Contributor
📊 Package size report 0.03%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
force-pushed
the
michalpiechowiak/frb-2057-malformed-next-redirect-url
branch
3 times, most recently
from
d8090ff to
152e581
Compare
pieh
force-pushed
the
michalpiechowiak/frb-2057-malformed-next-redirect-url
branch
from
152e581 to
81dd0ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is Next.js quirk where it sets or appends
locationheader multiple times. In specific cases it first set it and then append it, which results inlocationheader being twice in response. When usingnext startthis doesn't seem to cause actual problems, however you can seelocationheader twice:Despite the weirdness browsers work fine with it.
We however adapt NF's Fetch API
RequestandResponseto(req: http.IncomingMessage, res: http.ServerResponse)pair used under the hood by Next.js.Fetch API
Headershave different behavior - it will create single header with,delimeter ( https://github.com/nodejs/undici/blob/59fd5f4ee6b2da75cf5365c06c7a409f7ba3b206/lib/web/fetch/headers.js#L246-L250 )which result in reponses like so:
which breaks browser's behavior.
This adds a workaround to
res.appendHeaderthat we pass to Next.js to disallow appending same location againDocumentation
Tests
Added test case for the scenario in first commit (failing without code changes)