Improve Docker installation process by following steps of Docker official documentation#82
Merged
gab-arrobo merged 1 commit intoopennetworkinglab:mainfrom Apr 13, 2026
Conversation
…cial documentation Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
Updates the OnRamp documentation to better align the Docker installation guidance with Docker’s official workflow, especially around post-install group membership behavior that can affect immediate docker usage.
Changes:
- Added troubleshooting guidance explaining the need to refresh
dockergroup membership after Docker provisioning (logout/login ornewgrp docker). - Clarified that
make aether-gnbsim-installalready performs Docker provisioning, and whenmake gnbsim-docker-installis still useful as a standalone step.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
onramp/start.rst |
Adds a note about refreshing docker group membership before retrying docker exec after Docker is newly provisioned. |
onramp/gnbsim.rst |
Removes the implied requirement to run gnbsim-docker-install first, and documents what the Docker provisioning step does plus the group-membership refresh note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.