[ENH] Simplified Publish API with Automatic Type Recognition#1554
[ENH] Simplified Publish API with Automatic Type Recognition#1554Omswastik-11 wants to merge 13 commits intoopenml:mainfrom
Conversation
fkiraly
left a comment
There was a problem hiding this comment.
I get this is a draft still, some early comments.
- works for flows only, I would recommend to try for at least two different object types to see the dispatching challenge there.
- do the extension checking inside
publishand not in the usage example
|
Thanks @fkiraly !! |
|
The PR description is not entirely correct. This is how the interface looks currently: from openml_sklearn.extension import SklearnExtension
from sklearn.neighbors import KNeighborsClassifier
clf = KNeighborsClassifier(n_neighbors=3)
extension = SklearnExtension()# User instantiates the extension object
knn_flow = extension.model_to_flow(clf) # User manually converts the model (estimator instance) to an OpenMLFlow object
knn_flow.publish()But I like the idea of a unified |
Thanks for the correction I used the syntax example used in example script . this unified publish was Franz's idea . https://github.com/gc-os-ai/openml-project-dev/issues/8 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
- Coverage 52.04% 51.92% -0.12%
==========================================
Files 36 37 +1
Lines 4333 4358 +25
==========================================
+ Hits 2255 2263 +8
- Misses 2078 2095 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have added some comments. I also feel we should not populate |
initially
API