Skip to content

Conversation

@pshriwise
Copy link
Contributor

Description

During evaluation of the current CI failure in #3751 I noticed that the weight windows intended to be applied to photons in the regression test were being applied to neutrons due to the lack specification for a particle type on the corresponding WeightWindows object.

This fixes that and takes care of a few more "while we're here items":

  • removed some nuclides from the model material to reduce initialization time
  • increased the number of particles run slightly
  • added the collision checkpoint for weight windows

Like many of our regression tests, this is a very short run but I've confirmed from the tally results that the photons now do reach more mesh bins with weight windows turned on:

Neutrons

Analog

n_analog

Weight Windows

n_ww

Photons

Analog

p_analog

Weight Windows

p_ww

Checklist

@pshriwise pshriwise changed the title Set photon weight windows to be applied to photons Fix weight windows regression test Feb 12, 2026
Copy link
Contributor

@GuySten GuySten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@GuySten GuySten added the Merging Soon PR will be merged in < 24 hrs if no further comments are made. label Feb 12, 2026
@paulromano paulromano merged commit a3426cf into openmc-dev:develop Feb 12, 2026
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merging Soon PR will be merged in < 24 hrs if no further comments are made.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants