Fix weight windows regression test #3798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During evaluation of the current CI failure in #3751 I noticed that the weight windows intended to be applied to photons in the regression test were being applied to neutrons due to the lack specification for a particle type on the corresponding
WeightWindowsobject.This fixes that and takes care of a few more "while we're here items":
Like many of our regression tests, this is a very short run but I've confirmed from the tally results that the photons now do reach more mesh bins with weight windows turned on:
Neutrons
Analog
Weight Windows
Photons
Analog
Weight Windows
Checklist
I have run [clang-format](https://docs.openmc.org/en/latest/devguide/styleguide.html#automatic-formatting) (version 15) on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)