feat(closes OPEN-5988): openlayer-ts should accept csv datasets#178
Merged
gustavocidornelas merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
40c836a to
9b6c6c2
Compare
gustavocidornelas
requested changes
Jan 28, 2026
Contributor
gustavocidornelas
left a comment
There was a problem hiding this comment.
Added a few comments to version.ts.
Also, can you discard all changes outside of src/lib? Everything outside of it is auto-generated by Stainless, so this will cause issues. Version updates and changelog are fully handled by them based on the commit messages.
I recently wrote more details about SDK maintenance. I'm sure you know most of the things but sending here just in case.
Also, in the PR description, you mention unit tests but I don't see any. Make sure the description is accurate
9b6c6c2 to
cceb336
Compare
cceb336 to
baf057c
Compare
gustavocidornelas
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Adds CSV format support to the CLI dataset loading and writing functionality. The CLI now automatically detects and handles both JSON and CSV datasets based on file extension, maintaining format consistency between input and output files.
Changes
parseCsv,parseCsvLine)serializeCsv,escapeCsvValue)detectDatasetFormat)loadDatasetto support both JSON and CSV formatswriteDatasetto preserve input format in output filesCLIHandlerto use the new format-aware dataset functionsContext
Previously, the CLI only supported JSON datasets. This change enables users to work with CSV datasets, which are commonly used in data science workflows. The implementation handles edge cases like quoted values, commas within fields, and escaped quotes according to RFC 4180 standards.
Testing
Test Coverage:
Monitoring
Notes
"") correctly