Skip to content

Conversation

@mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented Jan 27, 2026

During speculative attribution of lambda expressions, we might get to the unary/binary op resolution code with erroneous types.
When this happens, type class witness resolution fails if Numerical/Integral are tweaked to contain witness methods.

This PR fixes this condition and adds a test.


Progress

  • Change must not contain extraneous whitespace

Reviewers without OpenJDK IDs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1981/head:pull/1981
$ git checkout pull/1981

Update a local copy of the PR:
$ git checkout pull/1981
$ git pull https://git.openjdk.org/valhalla.git pull/1981/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1981

View PR using the GUI difftool:
$ git pr show -t 1981

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1981.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2026

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into type-classes will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 27, 2026

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

[type-classes] Fix issue with type class op resolution inside speculative attribution

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the type-classes branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the type-classes branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2026

Webrevs

@mcimadamore mcimadamore changed the title [Type-classes] Fix issue with type class op resolution inside speculative attribution [type-classes] Fix issue with type class op resolution inside speculative attribution Jan 27, 2026
Beef up test to check various erroneous arguments permutations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants