8376430: [lworld] Remove Modifier.IDENTITY

[liach]

java.lang.reflect.Modifier represents Java language modifiers. Since a previous iteration of JEP 401, the "identity" source modifier is removed, and only "value" source modifier exists. As a result, "identity" is no longer qualified to be present in Modifier. We should migrate all its uses to ClassFile.ACC_IDENTITY or AccessFlag.IDENTITY (which already correctly identifies itself not as a source modifier).

This also avoids the headache of Modifier.toString clashing over SYNCHRONIZED versus IDENTITY.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8376430: [lworld] Remove Modifier.IDENTITY (Bug - P4)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Committer) ⚠️ Review applies to 48a3a442
• Joe Darcy (@jddarcy - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1980/head:pull/1980
$ git checkout pull/1980

Update a local copy of the PR:
$ git checkout pull/1980
$ git pull https://git.openjdk.org/valhalla.git pull/1980/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1980

View PR using the GUI difftool:
$ git pr show -t 1980

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1980.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8376430: [lworld] Remove Modifier.IDENTITY

Reviewed-by: vromero, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

• 9c8ed48: 8375074: [lworld] vmTestbase/nsk/jdi/ModificationWatchpointEvent/valueToBe/valuetobe001/TestDescription.java fails with --enable-preview

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full - Incremental (44fd9e37)
• 01: Full - Incremental (78694ae8)
• 00: Full (48a3a442)

[vicente-romero-oracle]

lgtm

[jddarcy]

Change "class modifiers" to "access flags" (or equivalent) or line 644.

[jddarcy]

Same comment as on line 644.

[jddarcy]

At a high-level, I concur that removing IDENTITY from Modifiers is the correct direction. The toString() methods of classes, or other affected constructs, can be updated to still print out source-level information even when the language and VM model a concept differently.

[liach]

Thanks for the reviews! Tier 1-2 passed.

/integrate

[openjdk]

Going to push as commit 0f2f43b.
Since your change was applied there has been 1 commit pushed to the lworld branch:

• 9c8ed48: 8375074: [lworld] vmTestbase/nsk/jdi/ModificationWatchpointEvent/valueToBe/valuetobe001/TestDescription.java fails with --enable-preview

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 0f2f43b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.