8376033: [lworld] Remove auto early construction from strict fields

[liach]

This is the 1st PR in the strict removal series. See #1951 for 2nd PR.

Remove the translation strategy change of javac from @Strict, and fix all resulting errors (which appear as verification error for class files).

This is a prerequisite for simplifying @Strict @NullRestricted to @NullRestricted later.

This is done by discovering @Strict fields that are:

1. Not a member of a value class
2. Not static

And use IDE refactor to move their initializer to the constructor, and add a super() call in the end of the constructor.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8376033: [lworld] Remove auto early construction from strict fields (Bug - P4)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1952/head:pull/1952
$ git checkout pull/1952

Update a local copy of the PR:
$ git checkout pull/1952
$ git pull https://git.openjdk.org/valhalla.git pull/1952/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1952

View PR using the GUI difftool:
$ git pr show -t 1952

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1952.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8376033: [lworld] Remove auto early construction from strict fields

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the lworld branch:

• a10bfdd: 8359147: [lworld] Print early_larval_frame in VerifyError reporting
• 2591e32: 8376088: [lworld] value class creation in CompileJavaModules.gmk leaves unnecessary files
• f62efbc: 8376105: [lworld] Handle "lworld" branch GHA dry-runs
• ... and 3 more: https://git.openjdk.org/valhalla/compare/43b6a7381591daa5fd431b2739358e29fa21221e...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 03: Full - Incremental (5b3d97b8)
• 02: Full - Incremental (35480f78)
• 01: Full - Incremental (6f876e27)
• 00: Full (bbc8fc5d)

[dansmithcode]

Oh, I was thinking the bulk adjustment to test constructors would come later, but this works too. From a high level point of view, doesn't look as bad as I thought it would be. :-)

[liach]

If we defer constructor adjustment to after @Strict and @NullRestricted merger, we would need javac to start dealing with @NullRestricted which IMO is more complicated. Will remove the temporary Flags.MARK_STRICT_INIT when we remove @Strict completely.

[vicente-romero-oracle]

lgtm

[liach]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit c259bd4.
Since your change was applied there have been 9 commits pushed to the lworld branch:

• 5c3e588: 8376411: [lworld] [BACKOUT] JDK-8376088 [lworld] value class creation in CompileJavaModules.gmk leaves unnecessary files
• 863089d: 8376042: [lworld] Revert changes to --patch-module handling
• b099d9c: 8373202: [lworld] ObjectReference.equals should follow == semantics for value objects
• ... and 6 more: https://git.openjdk.org/valhalla/compare/43b6a7381591daa5fd431b2739358e29fa21221e...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit c259bd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.