Fixing completion detection for null-restricted variables and fixing behavior for incorrect null-restricted variables without an initializer.

[lahodaj]

Fixing behavior in two cases:

• String! str = "" (i.e. missing semicolon) should work. This is achieved by fixing the completion analysis to report the snippet as COMPLETE_WITH_SEMI.
• String! str (i.e. missing initializer). This should produce an error saying initializer is required, achieved by not using the null initializer in this case.

---

Progress

• Change must not contain extraneous whitespace

Reviewers

• Vicente Romero (@vicente-romero-oracle - Committer)
• Maurizio Cimadamore (@mcimadamore - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1932/head:pull/1932
$ git checkout pull/1932

Update a local copy of the PR:
$ git checkout pull/1932
$ git pull https://git.openjdk.org/valhalla.git pull/1932/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1932

View PR using the GUI difftool:
$ git pr show -t 1932

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1932.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into bworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Fixing completion detection for null-restricted variables and fixing behavior for incorrect null-restricted variables without an initializer.

Reviewed-by: vromero, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the bworld branch:

• a30f387: Minor cleanup, preview and since
• 67758d3: add use site null checks for fields

Please see this link for an up-to-date comparison between the source branch of this pull request and the bworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle, @mcimadamore) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (8eefe1bb)

[vicente-romero-oracle]

lgtm

[mcimadamore]

Looks good!

[lahodaj]

/integrate

[openjdk]

@lahodaj
Your change (at version 8eefe1b) is now ready to be sponsored by a Committer.

[bridgekeeper]

@lahodaj This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@lahodaj This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.