Conversation
|
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
|
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
@gnu-andrew try |
Yes, I'm aware Please approve https://git.openjdk.org/jdk8u-dev/pull/787 and then this will be fixed in future PRs. |
|
/template append |
|
@gnu-andrew The pull request template has been appended to the pull request body |
jerboaa
left a comment
There was a problem hiding this comment.
Thumbs up! Pretty straight forward.
|
Thanks both for the reviews. I'll flag this now for approval, though it'll need to be rebased once #785 goes in. /approval request Regular update of the in-tree copy of giflib. GHA testing looks good and local testing shows no regressions. The patch was reviewed by Severin Gehwolf & Thomas Stuefe. |
|
@gnu-andrew |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8380078-dev
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
e66a52c to
c8a0692
Compare
|
@gnu-andrew Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
/integrate |
|
Going to push as commit 0c6fbe5. |
|
@gnu-andrew Pushed as commit 0c6fbe5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Part of getting giflib updated to 6.1.2 -- deferred from openjdk/jdk8u#89
This updates the in-tree giflib to 6.1.2. The actual code changes are a clean backport. The license file changes needed adapting from the giflib.md file in 11u and later to the THIRD_PARTY_README file in 8u (now only one copy following JDK-8338144)
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/786/head:pull/786$ git checkout pull/786Update a local copy of the PR:
$ git checkout pull/786$ git pull https://git.openjdk.org/jdk8u-dev.git pull/786/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 786View PR using the GUI difftool:
$ git pr show -t 786Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/786.diff
Using Webrev
Link to Webrev Comment