Skip to content

8380078: Update GIFlib to 6.1.2#786

Closed
gnu-andrew wants to merge 1 commit intoopenjdk:masterfrom
gnu-andrew:JDK-8380078-dev
Closed

8380078: Update GIFlib to 6.1.2#786
gnu-andrew wants to merge 1 commit intoopenjdk:masterfrom
gnu-andrew:JDK-8380078-dev

Conversation

@gnu-andrew
Copy link
Copy Markdown
Member

@gnu-andrew gnu-andrew commented Apr 14, 2026

Part of getting giflib updated to 6.1.2 -- deferred from openjdk/jdk8u#89

This updates the in-tree giflib to 6.1.2. The actual code changes are a clean backport. The license file changes needed adapting from the giflib.md file in 11u and later to the THIRD_PARTY_README file in 8u (now only one copy following JDK-8338144)



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8380078 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8380078: Update GIFlib to 6.1.2 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/786/head:pull/786
$ git checkout pull/786

Update a local copy of the PR:
$ git checkout pull/786
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 786

View PR using the GUI difftool:
$ git pr show -t 786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/786.diff

Using Webrev

Link to Webrev Comment

@gnu-andrew gnu-andrew mentioned this pull request Apr 14, 2026
6 tasks
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 14, 2026

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into pr/785 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 14, 2026

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8380078: Update GIFlib to 6.1.2

Reviewed-by: sgehwolf, stuefe
Backport-of: 970d6cf491a55fd6ab98ec3f449c13a58633078a

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 970d6cf491a55fd6ab98ec3f449c13a58633078a 8380078: Update GIFlib to 6.1.2 Apr 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 14, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Apr 14, 2026
@jerboaa
Copy link
Copy Markdown
Contributor

jerboaa commented Apr 14, 2026

@gnu-andrew try /template append

@gnu-andrew
Copy link
Copy Markdown
Member Author

@gnu-andrew try /template append

Yes, I'm aware

Please approve https://git.openjdk.org/jdk8u-dev/pull/787 and then this will be fixed in future PRs.

@gnu-andrew
Copy link
Copy Markdown
Member Author

/template append

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 15, 2026

@gnu-andrew The pull request template has been appended to the pull request body

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 15, 2026

Webrevs

Copy link
Copy Markdown
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up! Pretty straight forward.

Copy link
Copy Markdown
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gnu-andrew
Copy link
Copy Markdown
Member Author

Thanks both for the reviews. I'll flag this now for approval, though it'll need to be rebased once #785 goes in.

/approval request Regular update of the in-tree copy of giflib. GHA testing looks good and local testing shows no regressions. The patch was reviewed by Severin Gehwolf & Thomas Stuefe.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 16, 2026

@gnu-andrew
8380078: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Apr 16, 2026
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/785 to master April 16, 2026 21:02
@openjdk-notifier
Copy link
Copy Markdown

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8380078-dev
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 16, 2026

@gnu-andrew Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 16, 2026
Copy link
Copy Markdown
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2026
@gnu-andrew
Copy link
Copy Markdown
Member Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 17, 2026

Going to push as commit 0c6fbe5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 17, 2026
@openjdk openjdk bot closed this Apr 17, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 17, 2026

@gnu-andrew Pushed as commit 0c6fbe5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants