Skip to content

8373476: (tz) Update Timezone Data to 2025c#2545

Closed
xiezhaokun wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-xiezhaokun-5df183be-master
Closed

8373476: (tz) Update Timezone Data to 2025c#2545
xiezhaokun wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-xiezhaokun-5df183be-master

Conversation

@xiezhaokun
Copy link
Copy Markdown
Member

@xiezhaokun xiezhaokun commented Jan 14, 2026

tz2025c changes. clean backport of openjdk/jdk@5df183b


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373476 needs maintainer approval

Issue

  • JDK-8373476: (tz) Update Timezone Data to 2025c (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2545/head:pull/2545
$ git checkout pull/2545

Update a local copy of the PR:
$ git checkout pull/2545
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2545/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2545

View PR using the GUI difftool:
$ git pr show -t 2545

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2545.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Jan 14, 2026

👋 Welcome back zxie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jan 14, 2026

@xiezhaokun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373476: (tz) Update Timezone Data to 2025c

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport 5df183be6c484d8f9635fac149caf5e2079c5561 8373476: (tz) Update Timezone Data to 2025c Jan 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jan 14, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jan 14, 2026

⚠️ @xiezhaokun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jan 14, 2026
@xiezhaokun
Copy link
Copy Markdown
Member Author

/approval request backport

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jan 14, 2026

@xiezhaokun
8373476: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jan 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Jan 14, 2026

Webrevs

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 20, 2026
@vieiro
Copy link
Copy Markdown
Contributor

vieiro commented Jan 20, 2026

Hi,
I wonder if it's a good idea to run the tests in test/jdk/sun/util/calendar/zi in advance...

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received and removed ready Pull request is ready to be integrated labels Jan 22, 2026
@gnu-andrew
Copy link
Copy Markdown
Member

I've revoked approval until there is evidence of sufficient testing.

make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"

Copy link
Copy Markdown
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean but needs further testing

@xiezhaokun
Copy link
Copy Markdown
Member Author

I've revoked approval until there is evidence of sufficient testing.

make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"

I have executed the test cases, and there are no new failed test cases compared to the master branch.

@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Jan 31, 2026

Hi @xiezhaokun
please

@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Feb 3, 2026

Hi @xiezhaokun

I appreciate a lot you did all these backports.
Please continue working on them, these should all go into the April update.

Best, Goetz.

@gnu-andrew
Copy link
Copy Markdown
Member

I'm at a loss on the GHA failures. Why is testing being run in things like the arm cross compile?

Test selection 'java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources', will run:
* jtreg:test/jdk/java/text/Format
* jtreg:test/jdk/java/util/TimeZone
* jtreg:test/jdk/sun/util/calendar
* jtreg:test/jdk/sun/util/resources

It's failing because JTreg is not available there (it is installed by test.yml)

@gnu-andrew
Copy link
Copy Markdown
Member

I merged this branch with the latest 21u-dev and pushed it to my own fork. Let's see what the fresh GitHub Actions run shows: https://github.com/gnu-andrew/jdk21u-dev/actions/runs/21755824628

Copy link
Copy Markdown
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch is clean, and requested testing and my own GHA testing shows no regressions. I'm happy for this to go in.

@gnu-andrew
Copy link
Copy Markdown
Member

/approve yes

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 6, 2026

@gnu-andrew
8373476: The approval request has been approved.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Feb 6, 2026
@openjdk openjdk Bot removed the approval Requires approval; will be removed when approval is received label Feb 6, 2026
@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Feb 11, 2026

Hi @xiezhaokun
you can integrate now, please.

@xiezhaokun
Copy link
Copy Markdown
Member Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Feb 12, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 12, 2026

@xiezhaokun
Your change (at version bc83512) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 12, 2026

Going to push as commit 288dd1a.
Since your change was applied there have been 69 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Feb 12, 2026
@openjdk openjdk Bot closed this Feb 12, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 12, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 12, 2026

@gnu-andrew @xiezhaokun Pushed as commit 288dd1a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants