8373476: (tz) Update Timezone Data to 2025c#2545
8373476: (tz) Update Timezone Data to 2025c#2545xiezhaokun wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back zxie! A progress list of the required criteria for merging this PR into |
|
@xiezhaokun This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 69 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request backport |
|
@xiezhaokun |
|
Hi, |
|
I've revoked approval until there is evidence of sufficient testing. |
gnu-andrew
left a comment
There was a problem hiding this comment.
Confirmed clean but needs further testing
I have executed the test cases, and there are no new failed test cases compared to the master branch. |
|
Hi @xiezhaokun
|
|
Hi @xiezhaokun I appreciate a lot you did all these backports. Best, Goetz. |
|
I'm at a loss on the GHA failures. Why is testing being run in things like the arm cross compile? It's failing because JTreg is not available there (it is installed by |
|
I merged this branch with the latest 21u-dev and pushed it to my own fork. Let's see what the fresh GitHub Actions run shows: https://github.com/gnu-andrew/jdk21u-dev/actions/runs/21755824628 |
gnu-andrew
left a comment
There was a problem hiding this comment.
Patch is clean, and requested testing and my own GHA testing shows no regressions. I'm happy for this to go in.
|
/approve yes |
|
@gnu-andrew |
|
Hi @xiezhaokun |
|
/integrate |
|
@xiezhaokun |
|
/sponsor |
|
Going to push as commit 288dd1a.
Your commit was automatically rebased without conflicts. |
|
@gnu-andrew @xiezhaokun Pushed as commit 288dd1a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
tz2025c changes. clean backport of openjdk/jdk@5df183b
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2545/head:pull/2545$ git checkout pull/2545Update a local copy of the PR:
$ git checkout pull/2545$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2545/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2545View PR using the GUI difftool:
$ git pr show -t 2545Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2545.diff
Using Webrev
Link to Webrev Comment