8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor

[sendaoYan]

Hi all,

This pull request contains a backport of commit 390b2053 from the openjdk/jdk repository.

The commit being backported was authored by Leonid Mesnik on 17 Dec 2024 and was reviewed by David Holmes.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8346048 needs maintainer approval

Issue

• JDK-8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2513/head:pull/2513
$ git checkout pull/2513

Update a local copy of the PR:
$ git checkout pull/2513
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2513/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2513

View PR using the GUI difftool:
$ git pr show -t 2513

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2513.diff

Using Webrev

Link to Webrev Comment

[sendaoYan]

This backport will make 8370966 backported cleanly.

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• 2ce5030: 8356107: [java.lang] Use @requires tag instead of exiting based on os.name or separatorChar property
• 2f4c955: 8354219: Automate javax/swing/JComboBox/ComboPopupBug.java
• e96b4cd: 8355278: Improve debuggability of com/sun/jndi/ldap/LdapPoolTimeoutTest.java test
• ... and 35 more: https://git.openjdk.org/jdk21u-dev/compare/76aeaea7f479a3cae0178fe0e8dc1af6006fe5d8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 02: Full (789a8af4)
• 01: Full - Incremental (1abb601e)
• 00: Full (d14a3d30)

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

This seems fine, but the reason for it to get backported no longer applies. JDK-8370966 is already backported. Please resolve conflicts. Thanks!

[sendaoYan]

This seems fine, but the reason for it to get backported no longer applies. JDK-8370966 is already backported. Please resolve conflicts. Thanks!

Thanks for the remind. Fixed.

[sendaoYan]

/approval request Clean backport, trivial fix to avoid using methods from DockerRunOptions(). Test-fix only, no risk.

[openjdk]

@sendaoYan
8346048: The approval request has been created successfully.

[sendaoYan]

/approval request Clean backport, trivial fix to avoid using methods from DockerRunOptions(). Chang has been verified by run the test entry test/jdk/jdk/internal/platform/docker/TestPidsLimit.java manually. Test-fix only, no risk.

[openjdk]

@sendaoYan
8346048: The approval request has been updated successfully.

[sendaoYan]

/approval request Clean backport, trivial fix to avoid using methods from DockerRunOptions(). Chang has been verified by run the test entry test/jdk/jdk/internal/platform/docker/TestPidsLimit.java manually. Test-fix only, no risk.

[openjdk]

@sendaoYan
8346048: The approval request has been updated successfully.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8346048: The approval request has been approved.

[sendaoYan]

Thanks @jerboaa

/imtegrate

[openjdk]

@sendaoYan Unknown command imtegrate - for a list of valid commands use /help.

[sendaoYan]

/integrate

[openjdk]

Going to push as commit 1cda280.
Since your change was applied there have been 38 commits pushed to the master branch:

• 2ce5030: 8356107: [java.lang] Use @requires tag instead of exiting based on os.name or separatorChar property
• 2f4c955: 8354219: Automate javax/swing/JComboBox/ComboPopupBug.java
• e96b4cd: 8355278: Improve debuggability of com/sun/jndi/ldap/LdapPoolTimeoutTest.java test
• ... and 35 more: https://git.openjdk.org/jdk21u-dev/compare/76aeaea7f479a3cae0178fe0e8dc1af6006fe5d8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 1cda280.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.