Strip logging for non-trace errors#891
Open
markojovanov wants to merge 1 commit intoopenid:masterfrom
Open
Conversation
ankushkushwaha
approved these changes
Dec 16, 2024
Christophorus3
approved these changes
Oct 16, 2025
|
Can we please have some feedback on this? Or better, an approval so it can be merged and go into an upcoming release? |
Someone from the core team should review this pull request. |
ankushkushwaha
approved these changes
Oct 26, 2025
|
Who is part of the core team, to ping here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For OpenID Connect (OIDC) implementations, it is recommended to remove any logging from release builds for security and performance reasons. During my investigation of this project, I identified two log messages that were not covered by the newly introduced request trace mechanism, which was designed to allow logging only for debugging purposes.
This improvement aims to enhance security by ensuring that sensitive or unnecessary logs are not present in release builds.
Request:
If these log messages are intentional and have a specific purpose, please provide an explanation of why they should remain. Your feedback will help clarify their necessity.