Change or skip allowed time skew for ID token issue time validation#1033
Change or skip allowed time skew for ID token issue time validation#1033Mardaneus86 wants to merge 2 commits intoopenid:masterfrom
Conversation
Allows to completely disable ID tokens issue time validation, or change the default of 10 minutes to a custom allowed time skew in seconds.
|
This is a feature we've been waiting for for so long! Please review and accept, and we can move on from depending on v0.7.1 of the library :) |
|
Hi repo maintainers :) , Any news on this? Have been waiting for a month.... @WilliamDenniss @iainmcgin @StevenEWright |
|
agologan I see you seem to be one of the maintainers now? forgive me if I've misunderstood that. Any response to this PR please? We have been waiting a long time for this to be fixed. |
|
Any news on this ? |
|
@agologan Can you check this PR please ? |
|
On some mobile devices, users are required to manually set the time due to issues with the device’s time zone configuration—this is especially common with certain Chinese phones. Additionally, in some countries such as Iran, daylight saving time is inconsistently applied; it may be observed in some years and skipped in others. |
Checklist
Motivation and Context
Change aims to address issue in #830 by adding the ability to either disable or change the allowed time skew for the ID Token issued at time (
iat). Changing the allowed time skew can be useful because the clock on some devices can go beyond the default of 10 minutes. The OIDC specs do not define a specific timeframe, and the default of 10 minutes is still used when the new options are not used.Description
I followed a similar approach as #662 already did for skipping the issuer https check.