Skip to content

Move editor_saved to VideoConfigService #37823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
farhan wants to merge 2 commits into from
Closed

Move editor_saved to VideoConfigService #37823

farhan wants to merge 2 commits into from
+71 −59

Conversation

@farhan
Copy link
Contributor

@farhan farhan commented Dec 29, 2025 •
edited
Loading

Move editor_saved to VideoConfigService

This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282

Legacy Video Editor changes in this PR:

Removed:

  • studio_view() method

Not removed:

  1. editor_saved
  2. get_context() method
  3. EditingMixin usage

Why these methods still retained?
Removing these method breaks:

  1. Transcript uploads on the Video Block in the Content Library (Beta/V2).
  2. Fetching uploaded transcripts on authoring mfe video editor window.

To avoid this regression, they have been kept for now.

Below are the details of the testing.

Testing on Content Library (Beta/V2):

editor_saved method is called while uploading transcript on Content Library Video Block

  1. Go to any content library > Units tab
image
  1. Create a new unit and video block as a content in the unit.
image
  1. Save the video and then edit the video again to upload/add the transcript. Transcript should be uploaded/added successfully.
image

  1. Video and transcript should be render successfully in the content library preview.

  2. Go to any course, Add the block/unit from the library via 'Use unit from library' button

  3. Transcript should render successfully on the studio

  4. Publish the course transcript should render successfully on the studio

@farhan farhan force-pushed the farhan/move-editor-saved-to-service branch from 3f39899 to 75d98fb Compare December 29, 2025 09:19
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Dec 29, 2025
@open-craft-grove
Copy link

open-craft-grove commented Dec 29, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the farhan/move-editor-saved-to-service branch from 29d4497 to 26af990 Compare December 29, 2025 13:43
@open-craft-grove
Copy link

open-craft-grove commented Dec 29, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 29, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Base automatically changed from farhan/update-get-transcript-method to master December 30, 2025 06:59
@farhan farhan force-pushed the farhan/move-editor-saved-to-service branch from 1ab2b14 to ffca377 Compare December 30, 2025 07:41
@open-craft-grove
Copy link

open-craft-grove commented Dec 30, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 30, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the farhan/move-editor-saved-to-service branch from ffca377 to 6c11737 Compare December 30, 2025 09:47
@farhan
refactor: move editor_saved to VideoConfigService
4ac900a 
* This moves edx-platform-specific logic out of the VideoBlock,
in preparation for the VideoBlock extraction:
@farhan farhan force-pushed the farhan/move-editor-saved-to-service branch from 6c11737 to 4ac900a Compare December 30, 2025 09:55
@open-craft-grove
Copy link

open-craft-grove commented Dec 30, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 30, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Dec 30, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan removed the create-sandbox open-craft-grove should create a sandbox environment from this PR label Dec 30, 2025
@farhan farhan mentioned this pull request Dec 30, 2025
Merged
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Dec 30, 2025
@farhan
Copy link
Contributor Author

farhan commented Dec 31, 2025

Move the code to following PR because of sandbox issues in this PR.
#37829

@farhan farhan closed this Dec 31, 2025
@farhan farhan deleted the farhan/move-editor-saved-to-service branch January 6, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram will be requested when the pull request is marked ready for review irtazaakram is a code owner

@salman2013 salman2013 Awaiting requested review from salman2013 salman2013 will be requested when the pull request is marked ready for review salman2013 is a code owner

Assignees

No one assigned

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@farhan @open-craft-grove