Skip to content

Conversation

@farhan
Copy link
Contributor

@farhan farhan commented Dec 23, 2025

Description

This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282

Testing instructions

Testing has been done on the sandbox created within this PR.

  1. I have created youtube video xblock on studio/content-library
  2. I have uploaded the english/french transcripts on these video xblocks
  3. Transcripts feature is working fine on studio/content-library video xblocks
  4. Transcripts feature is working fine on lms for both course and library added video xblock in the course videos.

Note: Bumper video testing can't be done as not frontend exist for this feature. It seems un-used feature for some time.

Acceptance Criteria:

  • Transcripts feature should work for the video xblocks.
  • There should be no logic change.

Screenshot 2025-12-26 at 3 20 37 PM
Screenshot 2025-12-26 at 3 20 25 PM
Screenshot 2025-12-26 at 3 20 16 PM
Screenshot 2025-12-26 at 3 20 50 PM

@farhan farhan force-pushed the farhan/update-get-transcript-method branch from a5b790c to 9d02fbc Compare December 23, 2025 15:19
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change look good, be sure to add testing notes and I can re-review when that's done.

@farhan farhan force-pushed the farhan/update-get-transcript-method branch from 9d02fbc to 7d03b58 Compare December 24, 2025 07:33
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Dec 24, 2025
@farhan farhan force-pushed the farhan/update-get-transcript-method branch from 7d03b58 to dfe6525 Compare December 24, 2025 11:09
@farhan farhan closed this Dec 24, 2025
@farhan farhan reopened this Dec 24, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan force-pushed the farhan/update-get-transcript-method branch from dfe6525 to 7781a8d Compare December 26, 2025 13:59
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants