feat: Validate country input during student registration #37719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mphilbrick211 Hey can you look into this PR and the linked issue |
|
Hi @Waleed-Mujahid! Is this currently for a product proposal that's in progress? It might be that the Product team has not had a chance to review yet. |
Waleed-Mujahid
force-pushed
the
waleed/add-country-validation
branch
from
b04edbc to
2d03325
Compare
Added validation to ensure that the country code provided during student registration is valid. If the country code is invalid, an error message is appended to the row errors for appropriate feedback.
Waleed-Mujahid
force-pushed
the
waleed/add-country-validation
branch
from
2d03325 to
f7bca07
Compare
Contributor
Author
|
@mphilbrick211 hey the product review is complete. Can you ask someone to review this? |
Contributor
|
I agree with this change. Also commented with my approval on related issue: openedx/platform-roadmap#487 |
mphilbrick211
added
product review complete
mphilbrick211
added
the
needs reviewer assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While using the CSV enroll option in LMS instructor tab if an instructor use full country name instead ISO country code a general DataError is raised which can be confusing for instructors.
Roadmap
openedx/platform-roadmap#487
Before
After
Testing instructions
ALLOW_AUTOMATED_SIGNUPSas True in site configurationsNon-ISOcode formatDataError