bump poppler 26.05.0#3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates pdf2htmlEX’s Poppler integration to build against Poppler 26.05.0, primarily by adapting to Poppler API/ABI changes in matrix/string handling, font APIs, and background renderers, plus minor CI/build script updates.
Changes:
- Updated multiple renderer/code paths to use newer Poppler types/APIs (e.g.,
std::array::data(),GooStringstring accessors,WritingModeenum, updated stream APIs, and updated glyph/CID mapping APIs). - Adjusted background renderers (Splash/Cairo) for Poppler signature/enum changes and improved ownership semantics in proof rendering.
- Updated build configuration and automation (CMake module paths, GLib pkg-config checks, workflow runner version, and build scripts); removed legacy Travis CI config.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pdf2htmlEX/src/StateManager.h |
Uses std::array::data() for Poppler matrix storage when copying/comparing matrices. |
pdf2htmlEX/src/HTMLRenderer/text.cc |
Uses new GooString helpers and updated writing-mode check. |
pdf2htmlEX/src/HTMLRenderer/state.cc |
Updates CTM/TextMat access to match Poppler’s newer matrix storage API. |
pdf2htmlEX/src/HTMLRenderer/link.cc |
Adapts to updated AnnotColor::getValues() return type. |
pdf2htmlEX/src/HTMLRenderer/font.cc |
Updates Poppler stream/font APIs (rewind, bbox/matrix access, glyph lookup, FoFi load signature, CID/GID mapping, ToUnicode handling, writing-mode enum). |
pdf2htmlEX/src/DrawingTracer.cc |
Updates matrix access/copy to match Poppler’s newer matrix storage API. |
pdf2htmlEX/src/BackgroundRenderer/BackgroundRenderer.cc |
Uses std::make_unique for color spaces; updates TextMat access. |
pdf2htmlEX/src/BackgroundRenderer/SplashBackgroundRenderer.cc |
Updates SplashOutputDev ctor/beginString usage and Splash error handling API. |
pdf2htmlEX/src/BackgroundRenderer/CairoBackgroundRenderer.cc |
Updates writing-mode check and beginString base-call parameter type. |
pdf2htmlEX/CMakeLists.txt |
Adds module paths and GLib pkg-config discovery to support building against newer Poppler/GLib. |
buildScripts/versionEnvs |
Bumps POPPLER_VERSION to poppler-26.05.0. |
buildScripts/buildPdf2htmlEX |
Enables verbose make output. |
.travis.yml |
Removes Travis CI configuration. |
.github/workflows/build.yml |
Moves CI to ubuntu-24.04. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot stopped work on behalf of
andiwand due to an error
May 31, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.