Skip to content

bump poppler 26.05.0#3

Merged
andiwand merged 19 commits into
odr/mainfrom
bump-poppler-26.05.0
May 31, 2026
Merged

bump poppler 26.05.0#3
andiwand merged 19 commits into
odr/mainfrom
bump-poppler-26.05.0

Conversation

@andiwand
Copy link
Copy Markdown
Member

No description provided.

@andiwand andiwand marked this pull request as ready for review May 31, 2026 15:06
@andiwand andiwand requested a review from Copilot May 31, 2026 15:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates pdf2htmlEX’s Poppler integration to build against Poppler 26.05.0, primarily by adapting to Poppler API/ABI changes in matrix/string handling, font APIs, and background renderers, plus minor CI/build script updates.

Changes:

  • Updated multiple renderer/code paths to use newer Poppler types/APIs (e.g., std::array::data(), GooString string accessors, WritingMode enum, updated stream APIs, and updated glyph/CID mapping APIs).
  • Adjusted background renderers (Splash/Cairo) for Poppler signature/enum changes and improved ownership semantics in proof rendering.
  • Updated build configuration and automation (CMake module paths, GLib pkg-config checks, workflow runner version, and build scripts); removed legacy Travis CI config.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pdf2htmlEX/src/StateManager.h Uses std::array::data() for Poppler matrix storage when copying/comparing matrices.
pdf2htmlEX/src/HTMLRenderer/text.cc Uses new GooString helpers and updated writing-mode check.
pdf2htmlEX/src/HTMLRenderer/state.cc Updates CTM/TextMat access to match Poppler’s newer matrix storage API.
pdf2htmlEX/src/HTMLRenderer/link.cc Adapts to updated AnnotColor::getValues() return type.
pdf2htmlEX/src/HTMLRenderer/font.cc Updates Poppler stream/font APIs (rewind, bbox/matrix access, glyph lookup, FoFi load signature, CID/GID mapping, ToUnicode handling, writing-mode enum).
pdf2htmlEX/src/DrawingTracer.cc Updates matrix access/copy to match Poppler’s newer matrix storage API.
pdf2htmlEX/src/BackgroundRenderer/BackgroundRenderer.cc Uses std::make_unique for color spaces; updates TextMat access.
pdf2htmlEX/src/BackgroundRenderer/SplashBackgroundRenderer.cc Updates SplashOutputDev ctor/beginString usage and Splash error handling API.
pdf2htmlEX/src/BackgroundRenderer/CairoBackgroundRenderer.cc Updates writing-mode check and beginString base-call parameter type.
pdf2htmlEX/CMakeLists.txt Adds module paths and GLib pkg-config discovery to support building against newer Poppler/GLib.
buildScripts/versionEnvs Bumps POPPLER_VERSION to poppler-26.05.0.
buildScripts/buildPdf2htmlEX Enables verbose make output.
.travis.yml Removes Travis CI configuration.
.github/workflows/build.yml Moves CI to ubuntu-24.04.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pdf2htmlEX/CMakeLists.txt Outdated
Comment thread buildScripts/versionEnvs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@andiwand andiwand merged commit 4579074 into odr/main May 31, 2026
1 check passed
@andiwand andiwand deleted the bump-poppler-26.05.0 branch May 31, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants