fix broken menu item handling

[TomTasche]

Closes #442

[claude]

Claude finished @TomTasche's task —— View job

---

Claude Code has reviewed the PR

Review Tasks:

• Read and analyze the changes in DocumentFragment.java
• Review for code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Assess security concerns
• Check test coverage

---

Code Review Feedback

Summary

This PR fixes issue #442 by implementing proper menu item handling based on document type. The change replaces a hardcoded TODO with actual logic to dynamically enable/disable menu items based on the loaded document's capabilities.

Code Quality ✅

The implementation is clean and follows existing patterns in the codebase:

• Method naming (prepareMenu) is consistent with other prepare methods in the class
• Code structure matches the established pattern
• Proper separation of concerns between menu preparation and toggle logic

Bug Fixes ✅

The PR successfully addresses the issue where:

• Edit functionality was incorrectly enabled for ODS spreadsheets (known to be broken)
• Edit functionality was incorrectly enabled for PDF documents
• Dark mode was incorrectly available for PDFs

Potential Issues 🟡

1. Null Safety: The pageView.toggleDarkMode() call at line 348 could potentially throw NPE if pageView is null. Consider adding a null check:

   if (pageView != null) {
       pageView.toggleDarkMode(isDarkModeSupported);
   }

2. MIME Type Checking: Using startsWith() for MIME type checking works but could be more robust. Consider exact matches or a more comprehensive MIME type handling approach for future maintainability.

Performance ✅

The changes have minimal performance impact:

• Simple conditional checks with no heavy operations
• Method is only called when documents are loaded
• No additional loops or expensive operations

Security ✅

No security concerns identified:

• No user input handling
• No file system operations
• No network calls
• Simply toggles UI elements based on document type

Test Coverage ❌

Missing Tests: The PR doesn't include unit or integration tests for the new prepareMenu method. Consider adding tests to verify:

• Edit menu is disabled for ODS files
• Edit menu is disabled for PDF files
• Dark mode is disabled for PDFs
• Edit menu is enabled for other CORE document types

Recommendations

1. Add null safety check for pageView
2. Consider adding unit tests for the new menu preparation logic
3. For future iterations, consider extracting the document capability checks into a separate method or class for better testability and reusability

Overall, this is a solid fix that addresses the reported issue effectively. The code is clean and follows established patterns. Adding tests would make it production-ready.

---