fix allowed change ref types environment read#1253
Open
aoteropas wants to merge 6 commits intoopendevstack:masterfrom
Open
fix allowed change ref types environment read#1253aoteropas wants to merge 6 commits intoopendevstack:masterfrom
aoteropas wants to merge 6 commits intoopendevstack:masterfrom
Conversation
change the name of the variable in the if clause for the one that contains the env values. Follow the same approach that with other Env Variables
michaelsauter
previously approved these changes
Dec 4, 2023
Contributor
|
This change now make Webhook Proxy load the modified parameters but something is not working properly just yet |
when reading the env variable it is set to lower to unify the values. setting to lower the request information to ensure that comparison works
jafarre-bi
approved these changes
Dec 5, 2023
jafarre-bi
requested changes
Dec 5, 2023
jafarre-bi
left a comment
jafarre-bi
left a comment
There was a problem hiding this comment.
If these values are turned lowercase, allowedChangeRefTypesDefault should also have a lowercase value. Otherwise, the fix looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change the name of the variable in the if clause for the one that contains the env values. Follow the same approach that other Env Variables
Closes #1252