(Re)add ARM support on Windows and Linux #370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarny
force-pushed
the
issue368b
branch
3 times, most recently
from
ad756e9 to
5c6b494
Compare
LLVM+Clang was what forced us to give on Windows/Linux ARM. So, we went back to LLVM+Clang 14.0.3, the last version for which we were able to build for Windows/Linux ARM.
We were building them on ubuntu-20.04 because of glibc not including libpthread anymore (see https://developers.redhat.com/articles/2021/12/17/why-glibc-234-removed-libpthread) and that seems to be an issue when building our Python wheels. However, it looks like we could go around this problem by building libCellML (rather than using its prebuilt version) whenever we want to build our Python wheels (see opencor@b3f10c4#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR28).
agarny
force-pushed
the
issue368b
branch
4 times, most recently
from
d9011ea to
d6acd77
Compare
Removed some that are not necessary anymore (e.g., `LLVM_INCLUDE_GO_TESTS`) or are computed using LLVM-related arguments (e.g., `CLANG_INCLUDE_DOCS` and `CLANG_INCLUDE_TESTS`).
Contributor
Author
|
Closing in favour of PR #372. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368.