perf(get-component): cache acceptLanguageParser.parse results#1480
Open
ricardo-devis-agullo wants to merge 1 commit into
Open
perf(get-component): cache acceptLanguageParser.parse results#1480ricardo-devis-agullo wants to merge 1 commit into
ricardo-devis-agullo wants to merge 1 commit into
Conversation
acceptLanguageParser.parse is called on every data-provider request with the same Accept-Language header value. Since it's a pure function (same input → same output), cache the result using the existing nice-cache instance keyed by the raw header string. This avoids repeated parsing of identical Accept-Language headers across concurrent and sequential requests from the same browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acceptLanguageParser.parse is called on every data-provider request with
the same Accept-Language header value. Since it's a pure function (same
input → same output), cache the result using the existing nice-cache instance
keyed by the raw header string.
This avoids repeated parsing of identical Accept-Language headers across
concurrent and sequential requests from the same browser.