Skip to content

Conversation

@ishanrajsingh
Copy link
Contributor

Issue: #237

⚠️ This PR must be linked to a valid OpenCode issue number.
PRs without an issue number may not be reviewed.


Thank you for contributing to SubSentry 🚀
Please complete this template carefully to help mentors and bots review your PR efficiently.


📌 Description

Briefly explain what you implemented in this PR.

  • What problem does it solve?
  • What part of the project does it affect?

🧩 Issue Reference

Related Issue: #

Note: Do NOT use words like Closes, Fixes, or Resolves.
Issues are Open for All and should not be auto-closed.


🛠️ What Did You Implement?

Please list the major things you worked on in this PR:

  • Feature implementation
  • UI changes
  • API / backend logic
  • Refactor / cleanup
  • Documentation update
  • Demo / setup task

(Select all that apply)


📁 Workspace Confirmation (MANDATORY)

Since all issues are Open for All, confirm the following:

  • All changes are inside
    contributors/<your-github-username>/
  • Base client/ and/or server/ files were copied from the main directory
  • No files outside my personal workspace were modified

🧪 Testing Performed

Please check what applies:

  • Frontend runs locally without errors
  • Backend server runs locally without errors
  • APIs tested with valid inputs
  • APIs tested with invalid / edge-case inputs
  • No console errors or warnings

📷 Screenshots / Demo (REQUIRED for most PRs)

image

Please attach screenshots or recordings showing:

  • Folder structure
  • Major code changes
  • UI changes (if applicable)
  • Server / client running (for setup or demo issues)

PRs without screenshots for significant changes may be requested for updates.


✅ Final PR Checklist

Before submitting, ensure:

  • This PR addresses only one issue
  • Issue number is mentioned at the top
  • Code is readable and well-structured
  • No unnecessary files are included
  • No sensitive data or .env files committed
  • Commit messages follow project conventions
  • PR title is clear and descriptive

📎 Additional Notes for Reviewers

Add any extra context, assumptions, or known limitations here.


Thank you for contributing to SubSentry 💙
Your effort helps make this project better for everyone 🚀

@OpenGitBot
Copy link

Hey @ishanrajsingh

Thanks for opening this PR 🚀. Mentor will review your pull request soon and till then, keep contributing and stay calm.

Thanks for contributing in OpenCode'25 ✨✨!

@Aryan-coder06
Copy link
Collaborator

Aryan-coder06 commented Jan 20, 2026

Good start, but Issue #237 requires a clean parse pipeline. Current issues:

  • Parse endpoint uses a “fakeRes” hack; should call the service directly.
  • Uses the same OAuth flaws (no state, no per-user tokens, no encryption).
  • Should expose /api/gmail/parse (POST) and support optional groupByService.
  • Parser should extract service, amount, billing cycle, transaction type (rule-based).

Update these and we’ll re-review.

@ishanrajsingh
Copy link
Contributor Author

Hi @Aryan-coder06 , I have updated the code according to requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants