Skip to content

Add float type support for field comparison operations #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bomfanti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add float type support for field comparison operations #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions internal/analyzer/operations/operations_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,31 +103,31 @@ var operationsList = map[string]Operation{
"eqfield": {
CountValues: common.OneValue,
IsFieldOperation: true,
ValidTypes: []string{"<STRING>", "<INT>", "<BOOL>"},
ValidTypes: []string{"<STRING>", "<INT>", "<FLOAT>", "<BOOL>"},
},
"neqfield": {
CountValues: common.OneValue,
IsFieldOperation: true,
ValidTypes: []string{"<STRING>", "<INT>", "<BOOL>"},
ValidTypes: []string{"<STRING>", "<INT>", "<FLOAT>", "<BOOL>"},
},
"gtefield": {
CountValues: common.OneValue,
IsFieldOperation: true,
ValidTypes: []string{"<INT>"},
ValidTypes: []string{"<INT>", "<FLOAT>"},
},
"gtfield": {
CountValues: common.OneValue,
IsFieldOperation: true,
ValidTypes: []string{"<INT>"},
ValidTypes: []string{"<INT>", "<FLOAT>"},
},
"ltefield": {
CountValues: common.OneValue,
IsFieldOperation: true,
ValidTypes: []string{"<INT>"},
ValidTypes: []string{"<INT>", "<FLOAT>"},
},
"ltfield": {
CountValues: common.OneValue,
IsFieldOperation: true,
ValidTypes: []string{"<INT>"},
ValidTypes: []string{"<INT>", "<FLOAT>"},
},
}
128 changes: 128 additions & 0 deletions internal/analyzer/operations/operations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,66 @@ func TestOperationsIsValidByType(t *testing.T) {
valid: true,
},

// eqfield operations
{
op: "eqfield",
fieldTypes: []string{
"<STRING>", "<INT>", "<FLOAT>", "<BOOL>",
"*<STRING>", "*<INT>", "*<FLOAT>", "*<BOOL>",
},
valid: true,
},

// neqfield operations
{
op: "neqfield",
fieldTypes: []string{
"<STRING>", "<INT>", "<FLOAT>", "<BOOL>",
"*<STRING>", "*<INT>", "*<FLOAT>", "*<BOOL>",
},
valid: true,
},

// gtefield operations
{
op: "gtefield",
fieldTypes: []string{
"<INT>", "<FLOAT>",
"*<INT>", "*<FLOAT>",
},
valid: true,
},

// gtfield operations
{
op: "gtfield",
fieldTypes: []string{
"<INT>", "<FLOAT>",
"*<INT>", "*<FLOAT>",
},
valid: true,
},

// ltefield operations
{
op: "ltefield",
fieldTypes: []string{
"<INT>", "<FLOAT>",
"*<INT>", "*<FLOAT>",
},
valid: true,
},

// ltfield operations
{
op: "ltfield",
fieldTypes: []string{
"<INT>", "<FLOAT>",
"*<INT>", "*<FLOAT>",
},
valid: true,
},

// invalid cases
{
op: "email",
Expand Down Expand Up @@ -259,6 +319,74 @@ func TestOperationsIsValidByType(t *testing.T) {
fieldTypes: []string{"<INT>", "<FLOAT>", "<BOOL>", "[]<STRING>", "map[<STRING>]", "<XPTO>", "*<XPTO>"},
valid: false,
},
{
op: "eqfield",
fieldTypes: []string{
"[]<STRING>", "[]<INT>", "[]<FLOAT>", "[]<BOOL>",
"map[<STRING>]", "map[<INT>]", "map[<FLOAT>]", "map[<BOOL>]",
"*[]<STRING>", "*[]<INT>", "*[]<FLOAT>", "*[]<BOOL>",
"*map[<STRING>]", "*map[<INT>]", "*map[<FLOAT>]", "*map[<BOOL>]",
},
valid: false,
},
{
op: "neqfield",
fieldTypes: []string{
"[]<STRING>", "[]<INT>", "[]<FLOAT>", "[]<BOOL>",
"map[<STRING>]", "map[<INT>]", "map[<FLOAT>]", "map[<BOOL>]",
"*[]<STRING>", "*[]<INT>", "*[]<FLOAT>", "*[]<BOOL>",
"*map[<STRING>]", "*map[<INT>]", "*map[<FLOAT>]", "*map[<BOOL>]",
},
valid: false,
},
{
op: "gtefield",
fieldTypes: []string{
"<STRING>", "<BOOL>",
"[]<STRING>", "[]<INT>", "[]<FLOAT>", "[]<BOOL>",
"map[<STRING>]", "map[<INT>]", "map[<FLOAT>]", "map[<BOOL>]",
"*<STRING>", "*<BOOL>",
"*[]<STRING>", "*[]<INT>", "*[]<FLOAT>", "*[]<BOOL>",
"*map[<STRING>]", "*map[<INT>]", "*map[<FLOAT>]", "*map[<BOOL>]",
},
valid: false,
},
{
op: "gtfield",
fieldTypes: []string{
"<STRING>", "<BOOL>",
"[]<STRING>", "[]<INT>", "[]<FLOAT>", "[]<BOOL>",
"map[<STRING>]", "map[<INT>]", "map[<FLOAT>]", "map[<BOOL>]",
"*<STRING>", "*<BOOL>",
"*[]<STRING>", "*[]<INT>", "*[]<FLOAT>", "*[]<BOOL>",
"*map[<STRING>]", "*map[<INT>]", "*map[<FLOAT>]", "*map[<BOOL>]",
},
valid: false,
},
{
op: "ltefield",
fieldTypes: []string{
"<STRING>", "<BOOL>",
"[]<STRING>", "[]<INT>", "[]<FLOAT>", "[]<BOOL>",
"map[<STRING>]", "map[<INT>]", "map[<FLOAT>]", "map[<BOOL>]",
"*<STRING>", "*<BOOL>",
"*[]<STRING>", "*[]<INT>", "*[]<FLOAT>", "*[]<BOOL>",
"*map[<STRING>]", "*map[<INT>]", "*map[<FLOAT>]", "*map[<BOOL>]",
},
valid: false,
},
{
op: "ltfield",
fieldTypes: []string{
"<STRING>", "<BOOL>",
"[]<STRING>", "[]<INT>", "[]<FLOAT>", "[]<BOOL>",
"map[<STRING>]", "map[<INT>]", "map[<FLOAT>]", "map[<BOOL>]",
"*<STRING>", "*<BOOL>",
"*[]<STRING>", "*[]<INT>", "*[]<FLOAT>", "*[]<BOOL>",
"*map[<STRING>]", "*map[<INT>]", "*map[<FLOAT>]", "*map[<BOOL>]",
},
valid: false,
},
}

ops := New()
Expand Down