Improve access token refresh handling during network interruption#2129
Draft
Cassolette wants to merge 3 commits intoopencloud-eu:mainfrom
Draft
Improve access token refresh handling during network interruption#2129Cassolette wants to merge 3 commits intoopencloud-eu:mainfrom
Cassolette wants to merge 3 commits intoopencloud-eu:mainfrom
Conversation
Author
|
Not sure that I like brute forcing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR addresses two points;
6e61149 introduced handling in case of expired access tokens. It logs the user out forcefully as a fallback to avoid leaving the web UI in an unusable state. This fallback scenario can happen more frequently than expected as per linked issue, affecting the UX by requiring frequent credential keying. The fix is to not force a logout at the idp, but rather delegate the auth workflow over to the idp which will accurately determine the next step (re-authenticating if the session is still valid).
Make better efforts to allow successful silent signin during network downtime, reducing the occurrence of interruption in the UI or lost progress. We do this by retrying the silent sign in for 20 seconds if it fails due to a probable network error. It's not a bulletproof fix, and definitely does not cover all edge cases.
Related Issue
How Has This Been Tested?
Types of changes