fix: prevent sort options in trash overview from disappearing #1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where sort options in the trash overview disappear after emptying a trash bin. The fix ensures that the file list is only cleared when the user is inside a trash bin (i.e., when trash resources are present), not when viewing the trash overview.
Changes:
- Modified the
emptyTrashBinfunction to conditionally clear resources based on whether trash resources are present in the file list - Added test coverage for the new conditional clearing behavior
- Updated test imports to include
TrashResourcetype
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-pkg/src/composables/actions/files/useFileActionsEmptyTrashBin.ts | Added conditional logic to only clear resources when trash resources are present in the file list |
| packages/web-pkg/tests/unit/composables/actions/files/useFileActionsEmptyTrashBin.spec.ts | Added test case for the new conditional clearing behavior and updated existing test to verify resources are not cleared on overview |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prevents the sort options in the trash overview from disappearing after emptying a trash bin. This happened because we always cleared the file list afterwards, which should only happen when the user is inside a trash bin (not on the overview).
JammingBen
force-pushed
the
fix/trash-overview-sort-options-disappearing
branch
from
4ef268f to
c7d15dc
Compare
kulmann
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the sort options in the trash overview from disappearing after emptying a trash bin. This happened because we always cleared the file list afterwards, which should only happen when the user is inside a trash bin (not on the overview).
fixes #1391