fix: embed actions filename input and confirm button name #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues in the embed actions component: corrects the filename input field selection range and updates the confirm button label. The changes ensure that when a user saves a file through the embed action, the selection properly excludes the file extension (when extensions are shown) and the button text accurately reflects the "Save" action instead of "Choose".
Changes:
- Updated the confirm button label to conditionally display "Save" when choosing a filename
- Refactored the selection range calculation from a computed property to be set in onMounted lifecycle hook
- Added logic to properly calculate the selection range excluding file extensions when they are visible
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-app-files/src/components/EmbedActions/EmbedActions.vue
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix/embed-actions-filename-select
branch
from
e309078 to
56f25aa
Compare
Fixes the selection range on the embed actions filename input field and renames the confirm action to "Save" when using this.
JammingBen
force-pushed
the
fix/embed-actions-filename-select
branch
from
56f25aa to
7b599b8
Compare
kulmann
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the selection range on the embed actions filename input field and renames the confirm action to "Save" when using this. It must not compute on
fileNamebecause this would re-run every time the user inputs something. This only needs to happen initially.fixes #1630