Fix array minItems/maxItems bugs#2546
Open
simonsolnes wants to merge 2 commits intoopenapi-ts:mainfrom
Open
Conversation
… algorithm The loop was incorrectly generating tuples from 0 to (max-min) elements instead of min to max elements. For example, minItems: 1, maxItems: 3 was producing [] | [T] | [T, T] instead of [T] | [T, T] | [T, T, T].
🦋 Changeset detectedLatest commit: 44eb2fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
Contributor
|
Thank you! Would you mind adding a changeset for this (see comment)? |
8 tasks
… flag When an array's items was also an array type with minItems equal to maxItems, the generated TypeScript was getting incorrectly double-nested (e.g. string[][] instead of string[]). The issue was that the code checked if itemType was already an array/tuple to skip wrapping, but this incorrectly skipped wrapping for standard arrays when the nested transform happened to return an array type. Now we track whether the current schema defines a tuple (via prefixItems) separately.
simonsolnes
force-pushed
the
solnes/fix-minmax-bugs
branch
from
2c1266e to
44eb2fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix bugs related to minItems and maxItems when using
--array-lengthIssue: #1781
Fix incorrectly generating tuples from 0 to (max-min) elements instead of min to max elements.
For example, minItems: 1, maxItems: 3 was producing
[] | [T] | [T, T]instead of[T] | [T, T] | [T, T, T].When an array's items was also an array type with minItems equal to maxItems,
the generated TypeScript was getting incorrectly double-nested
(e.g.
string[][]instead ofstring[]).How to Review
The tests shows the expected results
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)