Skip to content

fix: handle bare dict annotations in construct_type #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Resurgamz wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

fix: handle bare dict annotations in construct_type #3386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/openai/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,10 @@ def construct_type(*, value: object, type_: object, metadata: Optional[List[Any]
if not is_mapping(value):
return value

_, items_type = get_args(type_) # Dict[_, items_type]
if len(args) < 2:
return value

_, items_type = args # Dict[_, items_type]
return {key: construct_type(value=item, type_=items_type) for key, item in value.items()}

if (
Expand Down
12 changes: 12 additions & 0 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,18 @@ class NestedModel(BaseModel):
assert cast(Any, m.nested) is False


def test_bare_dictionary() -> None:
class NestedModel(BaseModel):
nested: dict

m = NestedModel.construct(nested={"hello": {"world": True}})
assert m.nested == {"hello": {"world": True}}

# mismatched types
m = NestedModel.construct(nested=False)
assert cast(Any, m.nested) is False


def test_nested_dictionary_model() -> None:
class NestedModel(BaseModel):
nested: Dict[str, BasicModel]
Expand Down