fix(streaming): handle dupe-index delta entries#3204
Open
hrolfurinn wants to merge 1 commit intoopenai:mainfrom
Open
fix(streaming): handle dupe-index delta entries#3204hrolfurinn wants to merge 1 commit intoopenai:mainfrom
hrolfurinn wants to merge 1 commit intoopenai:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57597c785c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Handles case where multiple tool call entries in a single streaming delta share the same index. That dupe index shape is permissible according to the spec. Previously could result in initial tool call arg chunk being dropped, e.g. intended arguments
{ "city": "Reykjavik"}become truncatedcity": "Reykjavik" }. Bug was observed against vLLM with spec. decoding enabled.Route the first delta through the index-merge path. Duplicate-index entries now merge instead of becoming separate list elements. The early-return branches (
key not in acc,acc_value is None) copied the delta list as-is, skipping the merge. Same fix in_assistants.py._completions.pynow seeds initial snapshots throughaccumulate_delta.Additional context & links
Fixes #3203. See also #3201.