fix: apply hardened http client default to MCP SSE transport#3466
Merged
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror the redirect-hardening pattern from #3451 to the SSE transport.
MCPServerStreamableHttp.create_streams(server.py:1444-1446) always applies_create_default_streamable_http_client, which setsfollow_redirects=False.MCPServerSse.create_streams(server.py:1300-1301) only forwarded the factory when the user supplied one, so the default path fell through to MCP SDK'screate_mcp_http_client, which hasfollow_redirects=True.This PR aligns the two transports so the default SSE client picks up the same hardening as StreamableHTTP.
Test plan
tests/mcp/test_mcp_auth_params.py::test_sse_default_no_auth_no_factoryandtest_sse_with_authto assert the default factory is now always forwarded.test_sse_with_httpx_client_factory,test_sse_with_auth_and_factory) continue to pass unchanged.uv run pytest tests/mcp/— 209 passed.uv run ruff check/ruff format --check— clean.