fix: handle None refusal in extract_last_content#3465
Closed
nileshpatil6 wants to merge 1 commit into
Closed
Conversation
Member
|
Closing this for this reason: #3427 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ItemHelpers.extract_last_contentreturnslast_content.refusaldirectly when the last content block is a refusal. Provider gateways (e.g. LiteLLM) can surfaceNonefor typedstrfields, causing aTypeErrordownstream.PR #3394 already added
or ""to the.textbranch for this exact reason. The.refusalbranch was missed.This is the same fix attempted in PR #3428, which was incorrectly closed as a duplicate -- the PR it was supposedly a duplicate of (#3394) only covered
.text, not.refusal.