fix: serialize SQLite session writes with shared file locks#2843
Merged
fix: serialize SQLite session writes with shared file locks#2843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes SQLite session concurrency by sharing a process-local
RLockacross sessions that point at the same file-backed database and by runningAdvancedSQLiteSession.add_items()base-row insertion plus structure-metadata insertion inside one lock-protected critical section.It also routes branch/message-structure reads and writes through the same lock helper and adds regression coverage for shared file locks and concurrent
AdvancedSQLiteSessionwrites so message rows and structure rows stay aligned.