fix: reject history-rewriting handoffs with server-managed conversation#2746
Closed
sztoplover-bit wants to merge 1 commit intoopenai:mainfrom
Closed
fix: reject history-rewriting handoffs with server-managed conversation#2746sztoplover-bit wants to merge 1 commit intoopenai:mainfrom
sztoplover-bit wants to merge 1 commit intoopenai:mainfrom
Conversation
Member
|
Thanks for suggesting this change. We've been receiving this type of fail-fast validation for this issue, but I don't believe that could resolve the issue (I agree it could mitigate the issue by preventing data issue tho). I came up with an alternative #2747; if you have any feedback, it'd be appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversation_id,previous_response_id, andauto_previous_response_idWhy
Fixes #2151.
When
conversation_id,previous_response_id, orauto_previous_response_idis enabled, the server owns conversation history. Handoff input filters and nested handoff history rewrite the local history, which makes the next request diverge from the server-managed transcript.Instead of allowing that mismatch to surface later as a confusing API error or incorrect behavior, this change fails fast with a clear
UserError.Testing
.venv/bin/pytest tests/test_agent_runner.py -k 'server_managed_conversation'.venv/bin/pytest tests/test_run_step_processing.py -k 'handoff_can or missing_handoff_fails or multiple_handoffs_doesnt_error'