fix: #2489 lazily initialize tracing globals to avoid import-time fork hazards#2499
Merged
fix: #2489 lazily initialize tracing globals to avoid import-time fork hazards#2499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes import-time tracing side effects that could break fork-based process models by moving tracing bootstrap to lazy, first-use initialization. Importing
agentsno longer eagerly creates the defaultBackendSpanExporter(httpx.Client),BatchTraceProcessorthreading primitives, or the default provider wiring.The change updates tracing setup so
get_trace_provider()performs one-time lazy bootstrap (provider + default processor + shutdown registration) under locking, while preserving existing public tracing APIs. It also adds regression tests that validate no tracing globals are initialized onimport agents, that lazy bootstrap happens on first access, that bootstrap is one-time, and that explicitly setting a custom provider does not force default exporter/processor construction.This pull request resolves #2489.